fix(web): use if (dart.library.html) instead of if (dart.html)#2736
Merged
Conversation
buenaflor
requested review from
krystofwoldrich and
stefanosiano
as code owners
February 20, 2025 13:23
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## temp/8.13.2 #2736 +/- ##
==============================================
Coverage ? 92.22%
==============================================
Files ? 90
Lines ? 2931
Branches ? 0
==============================================
Hits ? 2703
Misses ? 228
Partials ? 0 ☔ View full report in Codecov by Sentry. |
buenaflor
commented
Feb 20, 2025
| expect(jsOptions['defaultIntegrations'][1].toString(), | ||
| contains('name: Dedupe')); | ||
| }); | ||
| // TODO: re-enable this test in V9 |
Contributor
Author
There was a problem hiding this comment.
let's skip this test for now since the dart:html part of it doesn't work anymore with the newest flutter version. we are going to remove the dart:html usages anyway in v9 so spending more time on fixing this is not needed
denrase
approved these changes
Feb 20, 2025
denrase
left a comment
denrase
left a comment
Collaborator
There was a problem hiding this comment.
Looks good, except failing analyzer.
kahest
approved these changes
Feb 20, 2025
buenaflor
added a commit
that referenced
this pull request
Feb 20, 2025
* update Android dependency to 7.22.0 (#2705) * fix: navigation breadcrumb with missing to crashes native (#2720) * release: 8.13.1 * update changelog * fix(web): use `if (dart.library.html)` instead of `if (dart.html)` (#2736) * fix * regenerate mocks * update CHANGELOG * update test * update * fix test * release: 8.13.2 --------- Co-authored-by: getsentry-bot <[email protected]> Co-authored-by: getsentry-bot <[email protected]>
buenaflor
added a commit
that referenced
this pull request
Mar 12, 2025
* update Android dependency to 7.22.0 (#2705) * fix: navigation breadcrumb with missing to crashes native (#2720) * release: 8.13.1 * update changelog * fix(web): use `if (dart.library.html)` instead of `if (dart.html)` (#2736) * fix * regenerate mocks * update CHANGELOG * update test * update * fix test * release: 8.13.2 * chore(deps): update Android SDK to v7.22.1 (#2785) * update android dep * update changelog * update CHANGELOG * release: 8.13.3 * update CHANGELOG --------- Co-authored-by: getsentry-bot <[email protected]> Co-authored-by: getsentry-bot <[email protected]>
buenaflor
added a commit
that referenced
this pull request
Mar 12, 2025
* update Android dependency to 7.22.0 (#2705) * fix: navigation breadcrumb with missing to crashes native (#2720) * release: 8.13.1 * update changelog * fix(web): use `if (dart.library.html)` instead of `if (dart.html)` (#2736) * fix * regenerate mocks * update CHANGELOG * update test * update * fix test * release: 8.13.2 * Use global ruby for `pod install` in min version test (#2783) * chore(deps): update Cocoa SDK to v8.46.0 (#2772) * chore: update flutter/scripts/update-cocoa.sh to 8.46.0 * Update CHANGELOG.md --------- Co-authored-by: GitHub <[email protected]> Co-authored-by: Giancarlo Buenaflor <[email protected]> * Bind root screen transaction to scope (#2756) * chore(deps): update Android SDK to v7.22.1 (#2785) * update android dep * update changelog * update CHANGELOG * release: 8.13.3 * update CHANGELOG * Prepare `8.14.0` changelog (#2787) * update CHANGELOG * update * Update CHANGELOG.md * Update CHANGELOG.md * release: 8.14.0 --------- Co-authored-by: getsentry-bot <[email protected]> Co-authored-by: Denis Andrašec <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: GitHub <[email protected]> Co-authored-by: getsentry-bot <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
💡 Motivation and Context
Fixes #2735
💚 How did you test it?
📝 Checklist
sendDefaultPiiis enabled🔮 Next steps