Codecov Report

Attention: Patch coverage is 95.34884% with 4 lines in your changes missing coverage. Please review.

Project coverage is 88.60%. Comparing base (7f8043c) to head (1f9fff6).
Report is 1 commits behind head on v9.

@@            Coverage Diff             @@
##               v9    #2730      +/-   ##
==========================================
+ Coverage   88.49%   88.60%   +0.10%     
==========================================
  Files         262      263       +1     
  Lines        8746     8760      +14     
==========================================
+ Hits         7740     7762      +22     
+ Misses       1006      998       -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Isn't the platform checker used to decide which native integration is called? So actually returning true for 'isMacOs' on web would cause the macos integrations to be called on web?

Isn't the platform checker used to decide which native integration is called? So actually returning true for 'isMacOs' on web would cause the macos integrations to be called on web?

I believe that was the case in the past but looking at how the code which calls hasNativeIntegration has evolved, it seems pretty useless now. Also, it's actually always true for the platforms we support:

  bool get hasNativeIntegration =>
      platform.isWeb ||
      platform.isAndroid ||
      platform.isIOS ||
      platform.isMacOS ||
      platform.isWindows ||
      platform.isLinux;
      ```

Error: A value of type 'SentryTransaction Function(SentryTransaction)' can't be assigned to a variable of type 'FutureOr<SentryTransaction?> Function(SentryTransaction, Hint)?'.
 - 'SentryTransaction' is from 'package:sentry/src/protocol/sentry_transaction.dart' ('../dart/lib/src/protocol/sentry_transaction.dart').
 - 'Hint' is from 'package:sentry/src/hint.dart' ('../dart/lib/src/hint.dart').
      fixture.options.beforeSendTransaction = (transaction) {
                                              ^
Shuffling test order with --test-randomize-ordering-seed=3637785904

doesn't seem related to the changes in this PR

we recently added hints to transactions, looks like flutter tests weren't updated

cc @denrase

@vaind picking this up now if its al right with you

🚨 Detected changes in high risk code 🚨

High-risk code has higher potential to break the SDK and may be hard to test. To prevent severe bugs, apply the rollout process for releasing such changes and be extra careful when changing and reviewing these files:

• flutter/lib/src/screenshot/recorder.dart

@vaind Still have left platform.supportsNativeIntegration as we still have fuchsia as a platform, but I'm not sure about this. Naming and also we can probably remove it, wdyt?

Fuchsia
I'd leave that in, the way it was (i.e. recognized but not supported.

supportsNativeIntegration

Yeah I didn't intend to remove this in the same PR, it's already big as it is.

@vaind Thank you!

@krystofwoldrich @stefanosiano Would be great if you could also do a review. 🙇‍♂️

@vaind @krystofwoldrich This should be ready to merge if you want to do a final review.