fix: auto ip guarded by sendDefaultPii#2726
Merged
Merged
Conversation
buenaflor
requested review from
krystofwoldrich and
stefanosiano
as code owners
February 17, 2025 16:07
Contributor
Author
|
cc @kahest, would this be considered breaking if we fix this in v8? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2726 +/- ##
=======================================
Coverage 88.99% 88.99%
=======================================
Files 263 263
Lines 8921 8923 +2
=======================================
+ Hits 7939 7941 +2
Misses 982 982 ☔ View full report in Codecov by Sentry. |
buenaflor
marked this pull request as draft
February 17, 2025 16:09
Contributor
Android Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| e893df5 | 310.60 ms | 380.58 ms | 69.98 ms |
| 8de999e | 475.70 ms | 531.38 ms | 55.68 ms |
| 636cb61 | 366.59 ms | 448.14 ms | 81.55 ms |
| 1596141 | 300.92 ms | 368.94 ms | 68.02 ms |
| 8bac8ba | 467.65 ms | 520.27 ms | 52.63 ms |
| e66e71e | 296.84 ms | 345.43 ms | 48.59 ms |
| 9555112 | 448.81 ms | 488.89 ms | 40.08 ms |
| 95c69e3 | 379.93 ms | 441.96 ms | 62.02 ms |
| 30c1193 | 349.00 ms | 438.20 ms | 89.20 ms |
| 6d317ea | 303.46 ms | 356.06 ms | 52.60 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| e893df5 | 6.06 MiB | 7.09 MiB | 1.03 MiB |
| 8de999e | 6.46 MiB | 7.48 MiB | 1.01 MiB |
| 636cb61 | 6.27 MiB | 7.20 MiB | 959.08 KiB |
| 1596141 | 6.16 MiB | 7.14 MiB | 1003.98 KiB |
| 8bac8ba | 6.46 MiB | 7.48 MiB | 1.03 MiB |
| e66e71e | 6.06 MiB | 7.09 MiB | 1.03 MiB |
| 9555112 | 6.52 MiB | 7.59 MiB | 1.06 MiB |
| 95c69e3 | 6.35 MiB | 7.35 MiB | 1021.71 KiB |
| 30c1193 | 6.27 MiB | 7.20 MiB | 958.74 KiB |
| 6d317ea | 5.94 MiB | 6.92 MiB | 1001.74 KiB |
Previous results on branch: fix/auto-ip-guarded-by-senddefault
Startup times
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 67a0ef4 | 470.94 ms | 572.15 ms | 101.21 ms |
| a2684a2 | 411.91 ms | 498.44 ms | 86.53 ms |
| dcae18c | 480.57 ms | 540.11 ms | 59.53 ms |
| 87893cc | 415.68 ms | 502.84 ms | 87.16 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 67a0ef4 | 6.46 MiB | 7.48 MiB | 1.02 MiB |
| a2684a2 | 6.46 MiB | 7.48 MiB | 1.02 MiB |
| dcae18c | 6.46 MiB | 7.48 MiB | 1.02 MiB |
| 87893cc | 6.46 MiB | 7.48 MiB | 1.02 MiB |
Contributor
as discussed - yes we should ship it in a v8 minor with very clear callout on the change log, similar to other platforms (e.g. .NET, Java/Android) |
kahest
reviewed
Feb 17, 2025
kahest
left a comment
kahest
left a comment
Contributor
There was a problem hiding this comment.
apart from missing changelog, LGTM
Contributor
iOS Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| e82709a | 1249.22 ms | 1271.35 ms | 22.12 ms |
| 1cc9547 | 1230.81 ms | 1260.79 ms | 29.98 ms |
| 99704d2 | 1241.74 ms | 1258.00 ms | 16.26 ms |
| 934f10e | 1245.18 ms | 1263.77 ms | 18.59 ms |
| 6aab859 | 1245.14 ms | 1247.59 ms | 2.45 ms |
| 0118295 | 1211.31 ms | 1227.02 ms | 15.71 ms |
| 8fe0817 | 1235.41 ms | 1245.51 ms | 10.10 ms |
| d7dc4e5 | 1249.15 ms | 1275.63 ms | 26.49 ms |
| f4cc744 | 1274.57 ms | 1290.79 ms | 16.22 ms |
| 3a43905 | 1254.31 ms | 1266.35 ms | 12.04 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| e82709a | 8.33 MiB | 9.40 MiB | 1.07 MiB |
| 1cc9547 | 8.42 MiB | 9.86 MiB | 1.44 MiB |
| 99704d2 | 8.42 MiB | 9.87 MiB | 1.44 MiB |
| 934f10e | 8.38 MiB | 9.77 MiB | 1.39 MiB |
| 6aab859 | 8.29 MiB | 9.36 MiB | 1.07 MiB |
| 0118295 | 8.32 MiB | 9.38 MiB | 1.05 MiB |
| 8fe0817 | 8.29 MiB | 9.39 MiB | 1.10 MiB |
| d7dc4e5 | 8.42 MiB | 9.91 MiB | 1.48 MiB |
| f4cc744 | 8.16 MiB | 9.16 MiB | 1.01 MiB |
| 3a43905 | 8.10 MiB | 9.18 MiB | 1.08 MiB |
Previous results on branch: fix/auto-ip-guarded-by-senddefault
Startup times
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 87893cc | 1258.94 ms | 1272.43 ms | 13.49 ms |
| a2684a2 | 1251.69 ms | 1269.94 ms | 18.24 ms |
| 67a0ef4 | 1252.20 ms | 1267.39 ms | 15.18 ms |
| dcae18c | 1237.86 ms | 1261.09 ms | 23.23 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 87893cc | 8.42 MiB | 9.91 MiB | 1.49 MiB |
| a2684a2 | 8.42 MiB | 9.91 MiB | 1.49 MiB |
| 67a0ef4 | 8.42 MiB | 9.91 MiB | 1.49 MiB |
| dcae18c | 8.42 MiB | 9.91 MiB | 1.49 MiB |
buenaflor
commented
Feb 19, 2025
buenaflor
marked this pull request as ready for review
February 19, 2025 13:03
denrase
requested changes
Feb 19, 2025
denrase
approved these changes
Feb 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
💡 Motivation and Context
Previously wasn't guarded by
sendDefaultPiibecause of #1562getsentry/team-sdks#118 states it should only be added if
sendDefaultPii = true💚 How did you test it?
Unit test
📝 Checklist
sendDefaultPiiis enabled🔮 Next steps