deprecate: drift SentryQueryExecutor#2715
Merged
Merged
Conversation
buenaflor
requested review from
krystofwoldrich and
stefanosiano
as code owners
February 13, 2025 15:25
buenaflor
changed the title
SentryQueryExecutor
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2715 +/- ##
==========================================
+ Coverage 88.99% 91.66% +2.66%
==========================================
Files 263 93 -170
Lines 8921 3082 -5839
==========================================
- Hits 7939 2825 -5114
+ Misses 982 257 -725 ☔ View full report in Codecov by Sentry. |
Contributor
Android Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 8fe0817 | 317.28 ms | 378.80 ms | 61.52 ms |
| 6fedcab | 388.26 ms | 487.42 ms | 99.16 ms |
| 5e8d2b3 | 342.17 ms | 375.83 ms | 33.66 ms |
| 33d0587 | 308.79 ms | 370.86 ms | 62.07 ms |
| 3e5ee37 | 317.56 ms | 366.84 ms | 49.28 ms |
| d5f600b | 392.88 ms | 466.73 ms | 73.85 ms |
| 1edf30e | 334.00 ms | 378.35 ms | 44.35 ms |
| 5aab4c5 | 326.12 ms | 378.82 ms | 52.70 ms |
| a24a1db | 400.58 ms | 499.75 ms | 99.17 ms |
| df16b96 | 326.08 ms | 391.82 ms | 65.74 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 8fe0817 | 6.16 MiB | 7.14 MiB | 1011.25 KiB |
| 6fedcab | 6.33 MiB | 7.30 MiB | 987.83 KiB |
| 5e8d2b3 | 6.15 MiB | 7.13 MiB | 1000.11 KiB |
| 33d0587 | 6.16 MiB | 7.14 MiB | 1007.47 KiB |
| 3e5ee37 | 5.94 MiB | 6.92 MiB | 1001.19 KiB |
| d5f600b | 6.33 MiB | 7.26 MiB | 943.41 KiB |
| 1edf30e | 5.94 MiB | 6.96 MiB | 1.02 MiB |
| 5aab4c5 | 6.06 MiB | 7.10 MiB | 1.04 MiB |
| a24a1db | 6.46 MiB | 7.48 MiB | 1.02 MiB |
| df16b96 | 6.06 MiB | 7.03 MiB | 988.94 KiB |
Contributor
iOS Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 0095354 | 1241.96 ms | 1269.25 ms | 27.29 ms |
| 00236a7 | 1250.06 ms | 1274.00 ms | 23.94 ms |
| f7f46dc | 1285.82 ms | 1315.06 ms | 29.24 ms |
| 4b5a4f6 | 1245.28 ms | 1272.27 ms | 26.99 ms |
| c732386 | 1233.20 ms | 1252.08 ms | 18.88 ms |
| 32fa6b6 | 1226.21 ms | 1251.78 ms | 25.57 ms |
| 1a93825 | 1257.25 ms | 1261.55 ms | 4.30 ms |
| d0476e1 | 1259.45 ms | 1280.31 ms | 20.86 ms |
| d5f600b | 1220.79 ms | 1232.93 ms | 12.14 ms |
| 61e71ec | 1243.14 ms | 1257.21 ms | 14.07 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 0095354 | 8.38 MiB | 9.78 MiB | 1.40 MiB |
| 00236a7 | 8.38 MiB | 9.77 MiB | 1.39 MiB |
| f7f46dc | 8.10 MiB | 9.17 MiB | 1.08 MiB |
| 4b5a4f6 | 8.32 MiB | 9.39 MiB | 1.07 MiB |
| c732386 | 8.28 MiB | 9.33 MiB | 1.05 MiB |
| 32fa6b6 | 8.33 MiB | 9.64 MiB | 1.31 MiB |
| 1a93825 | 8.28 MiB | 9.34 MiB | 1.05 MiB |
| d0476e1 | 8.33 MiB | 9.64 MiB | 1.31 MiB |
| d5f600b | 8.32 MiB | 9.38 MiB | 1.05 MiB |
| 61e71ec | 8.33 MiB | 9.40 MiB | 1.07 MiB |
denrase
approved these changes
Feb 14, 2025
denrase
left a comment
denrase
left a comment
Collaborator
There was a problem hiding this comment.
Analyzer issues remaining, as we use the now deprecated class in tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will be replaced in v9 by
SentryQueryInterceptor