fix: message of frames tracking warning#2704
Merged
Merged
Conversation
buenaflor
requested review from
krystofwoldrich and
stefanosiano
as code owners
February 11, 2025 22:49
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2704 +/- ##
==========================================
+ Coverage 88.99% 92.09% +3.09%
==========================================
Files 263 91 -172
Lines 8921 2946 -5975
==========================================
- Hits 7939 2713 -5226
+ Misses 982 233 -749 ☔ View full report in Codecov by Sentry. |
Contributor
Android Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| cd16818 | 316.57 ms | 375.19 ms | 58.62 ms |
| 42f6e7e | 308.71 ms | 360.06 ms | 51.35 ms |
| 2261c15 | 370.00 ms | 455.88 ms | 85.88 ms |
| 3ad66e4 | 406.90 ms | 481.48 ms | 74.58 ms |
| 4477d2e | 392.75 ms | 472.69 ms | 79.94 ms |
| fcd1ee4 | 298.96 ms | 376.04 ms | 77.09 ms |
| d089990 | 361.67 ms | 442.50 ms | 80.83 ms |
| 4c13d97 | 455.34 ms | 509.42 ms | 54.08 ms |
| 7359546 | 458.04 ms | 522.60 ms | 64.56 ms |
| 24b6e60 | 440.64 ms | 557.96 ms | 117.32 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| cd16818 | 6.26 MiB | 7.20 MiB | 956.08 KiB |
| 42f6e7e | 6.27 MiB | 7.20 MiB | 956.06 KiB |
| 2261c15 | 6.27 MiB | 7.20 MiB | 957.75 KiB |
| 3ad66e4 | 6.33 MiB | 7.26 MiB | 947.04 KiB |
| 4477d2e | 6.33 MiB | 7.26 MiB | 950.38 KiB |
| fcd1ee4 | 6.16 MiB | 7.13 MiB | 1000.85 KiB |
| d089990 | 6.34 MiB | 7.28 MiB | 967.79 KiB |
| 4c13d97 | 6.49 MiB | 7.56 MiB | 1.07 MiB |
| 7359546 | 6.46 MiB | 7.48 MiB | 1.01 MiB |
| 24b6e60 | 6.33 MiB | 7.26 MiB | 950.14 KiB |
Contributor
iOS Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| cecd4ed | 1232.88 ms | 1250.65 ms | 17.78 ms |
| 0ac1eed | 1278.51 ms | 1285.29 ms | 6.78 ms |
| 9f9f94f | 1268.33 ms | 1284.73 ms | 16.41 ms |
| 4b29d6e | 1208.18 ms | 1230.92 ms | 22.73 ms |
| 0aaa46e | 1256.39 ms | 1276.41 ms | 20.02 ms |
| ed2ae08 | 1222.10 ms | 1226.57 ms | 4.47 ms |
| f4cc744 | 1274.57 ms | 1290.79 ms | 16.22 ms |
| 613760b | 1263.10 ms | 1277.27 ms | 14.16 ms |
| 7fd33d3 | 1241.92 ms | 1265.47 ms | 23.55 ms |
| df16b96 | 1255.24 ms | 1259.40 ms | 4.16 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| cecd4ed | 8.38 MiB | 9.75 MiB | 1.37 MiB |
| 0ac1eed | 8.10 MiB | 9.16 MiB | 1.07 MiB |
| 9f9f94f | 8.15 MiB | 9.15 MiB | 1020.76 KiB |
| 4b29d6e | 8.32 MiB | 9.38 MiB | 1.05 MiB |
| 0aaa46e | 8.29 MiB | 9.38 MiB | 1.09 MiB |
| ed2ae08 | 8.28 MiB | 9.34 MiB | 1.06 MiB |
| f4cc744 | 8.16 MiB | 9.16 MiB | 1.01 MiB |
| 613760b | 8.15 MiB | 9.13 MiB | 1000.46 KiB |
| 7fd33d3 | 8.38 MiB | 9.78 MiB | 1.40 MiB |
| df16b96 | 8.10 MiB | 9.16 MiB | 1.06 MiB |
denrase
approved these changes
Feb 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
Fixes wrong warning message in frames tracking integration
💡 Motivation and Context
Closes #2703