[v9] Enable JS SDK native integration by default#2688
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## v9 #2688 +/- ##
==========================================
- Coverage 88.31% 88.24% -0.07%
==========================================
Files 262 263 +1
Lines 8911 8918 +7
==========================================
Hits 7870 7870
- Misses 1041 1048 +7 ☔ View full report in Codecov by Sentry. |
buenaflor
marked this pull request as ready for review
February 12, 2025 15:06
buenaflor
requested review from
krystofwoldrich and
stefanosiano
as code owners
February 12, 2025 15:06
denrase
requested changes
Feb 13, 2025
denrase
left a comment
denrase
left a comment
Collaborator
There was a problem hiding this comment.
We still access options.enableSentryJs = true; in the tests
| @@ -165,7 +164,6 @@ void main() { | |||
| testWidgets('Sentry JS SDK is not initialized', (tester) async { | |||
Collaborator
There was a problem hiding this comment.
Do we even need this test, as we always enable by default? If not, we can also remove the enabled group.
Contributor
Author
There was a problem hiding this comment.
depends, this specifically tests that if autoInitializeNativeSdks = false then we won't init the SDK
I forgot the autoInitializeNativeSdks = false
denrase
approved these changes
Feb 14, 2025
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
💡 Motivation and Context
Closes #2634
💚 How did you test it?
Existing tests
📝 Checklist
sendDefaultPiiis enabled🔮 Next steps