Skip to content

[v9]: Add hint for transactions#2675

Merged
denrase merged 12 commits into
v9from
v9-before-send-transaction-hint
Feb 12, 2025
Merged

[v9]: Add hint for transactions#2675
denrase merged 12 commits into
v9from
v9-before-send-transaction-hint

Conversation

@denrase

@denrase denrase commented Feb 10, 2025

Copy link
Copy Markdown
Collaborator

📜 Description

Add hint for transactions

💡 Motivation and Context

Closes #2635

💚 How did you test it?

Tests

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPii is enabled
  • I updated the docs if needed
  • All tests passing
  • No breaking changes

🔮 Next steps

@codecov

codecov Bot commented Feb 10, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.16%. Comparing base (98d6f2d) to head (87a961d).
Report is 1 commits behind head on v9.

Additional details and impacted files
@@           Coverage Diff           @@
##               v9    #2675   +/-   ##
=======================================
  Coverage   89.16%   89.16%           
=======================================
  Files         261      261           
  Lines        8829     8830    +1     
=======================================
+ Hits         7872     7873    +1     
  Misses        957      957           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@denrase
denrase marked this pull request as ready for review February 10, 2025 14:13

@buenaflor buenaflor left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good on first pass 👍

Comment thread CHANGELOG.md Outdated
@denrase
denrase requested a review from buenaflor February 11, 2025 09:37

@buenaflor buenaflor left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! thx

@denrase
denrase merged commit 3ab3095 into v9 Feb 12, 2025
@denrase
denrase deleted the v9-before-send-transaction-hint branch February 12, 2025 14:39
@vaind vaind mentioned this pull request Feb 18, 2025
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants