[v9]: remove manual TTID#2668
Merged
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## v9 #2668 +/- ##
==========================================
+ Coverage 89.09% 92.41% +3.32%
==========================================
Files 262 89 -173
Lines 8882 2886 -5996
==========================================
- Hits 7913 2667 -5246
+ Misses 969 219 -750 ☔ View full report in Codecov by Sentry. |
buenaflor
marked this pull request as ready for review
February 6, 2025 13:36
buenaflor
requested review from
krystofwoldrich and
stefanosiano
as code owners
February 6, 2025 13:36
denrase
approved these changes
Feb 10, 2025
denrase
left a comment
denrase
left a comment
Collaborator
There was a problem hiding this comment.
Looking good. Can we remove manualUiTimeToDisplay from SentryTraceOrigins?
Contributor
Author
|
@denrase that origin is still relevant for TTFD |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
💡 Motivation and Context
v9 Task
💚 How did you test it?
Closes #2636
📝 Checklist
sendDefaultPiiis enabled🔮 Next steps