Skip to content

[v9]: Remove screenshot option attachScreenshotOnlyWhenResumed #2664

Merged
denrase merged 6 commits into
v9from
v9-remove-screenshot-attach-only-when-resumed
Feb 10, 2025
Merged

[v9]: Remove screenshot option attachScreenshotOnlyWhenResumed #2664
denrase merged 6 commits into
v9from
v9-remove-screenshot-attach-only-when-resumed

Conversation

@denrase

@denrase denrase commented Feb 5, 2025

Copy link
Copy Markdown
Collaborator

📜 Description

Remove screenshot option attachScreenshotOnlyWhenResumed

💡 Motivation and Context

Closes #2639

💚 How did you test it?

CI

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPii is enabled
  • I updated the docs if needed
  • All tests passing
  • No breaking changes

@codecov

codecov Bot commented Feb 5, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.50%. Comparing base (79ccefb) to head (bbc70b9).
Report is 214 commits behind head on v9.

Additional details and impacted files
@@             Coverage Diff             @@
##               v9    #2664       +/-   ##
===========================================
+ Coverage   67.94%   92.50%   +24.55%     
===========================================
  Files          15       90       +75     
  Lines         443     2908     +2465     
===========================================
+ Hits          301     2690     +2389     
- Misses        142      218       +76     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@denrase
denrase marked this pull request as ready for review February 5, 2025 14:31
# Conflicts:
#	flutter/lib/src/sentry_flutter_options.dart
@denrase
denrase merged commit 496768f into v9 Feb 10, 2025
@denrase
denrase deleted the v9-remove-screenshot-attach-only-when-resumed branch February 10, 2025 10:15
@vaind vaind mentioned this pull request Feb 18, 2025
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants