[v9] Remove deprecated beforeScreenshot#2662
Merged
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## v9 #2662 +/- ##
==========================================
+ Coverage 89.07% 92.44% +3.36%
==========================================
Files 262 90 -172
Lines 8887 2911 -5976
==========================================
- Hits 7916 2691 -5225
+ Misses 971 220 -751 ☔ View full report in Codecov by Sentry. |
denrase
marked this pull request as ready for review
February 5, 2025 13:46
denrase
requested review from
buenaflor,
krystofwoldrich and
stefanosiano
as code owners
February 5, 2025 13:46
buenaflor
reviewed
Feb 5, 2025
buenaflor
left a comment
buenaflor
left a comment
Contributor
There was a problem hiding this comment.
looks good! let's do the android api bump separately
buenaflor
reviewed
Feb 5, 2025
Comment on lines
+22
to
+24
| # bump minSdkVersion to 21 | ||
| gradleFile="$targetDir/perf-test-app-with-sentry/android/app/build.gradle" | ||
| sed "s/flutter.minSdkVersion/19/g" "$gradleFile" > "$gradleFile.new" && mv "$gradleFile.new" "$gradleFile" | ||
| sed "s/flutter.minSdkVersion/21/g" "$gradleFile" > "$gradleFile.new" && mv "$gradleFile.new" "$gradleFile" |
Contributor
There was a problem hiding this comment.
we can revert this as well right?
Collaborator
Author
There was a problem hiding this comment.
Does not build with version 19, it seems most recent version of sentry-android does not support 19?
Contributor
There was a problem hiding this comment.
ah yeah android bumped api from 19 to 21, let's leave it then. but we can do the minSDK bump separately
buenaflor
approved these changes
Feb 6, 2025
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
Remove deprecated
beforeScreenshot💡 Motivation and Context
Closes #2642
💚 How did you test it?
Unit tests
📝 Checklist
sendDefaultPiiis enabled