Skip to content

refactor: workaround capture issue#2657

Merged
vaind merged 6 commits into
mainfrom
refactor/workaround-capture-issue
Feb 5, 2025
Merged

refactor: workaround capture issue#2657
vaind merged 6 commits into
mainfrom
refactor/workaround-capture-issue

Conversation

@vaind

@vaind vaind commented Feb 4, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

📜 Description

💡 Motivation and Context

💚 How did you test it?

Manually with custom code that captures at a higher frame rate to more readily reproduce the issue.

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPii is enabled
  • I updated the docs if needed
  • All tests passing
  • No breaking changes

🔮 Next steps

#skip-changelog - later for 8.13, I'll merge the changelog item with the original fix

@github-actions

github-actions Bot commented Feb 4, 2025

Copy link
Copy Markdown
Contributor

🚨 Detected changes in high risk code 🚨

High-risk code has higher potential to break the SDK and may be hard to test. To prevent severe bugs, apply the rollout process for releasing such changes and be extra careful when changing and reviewing these files:

  • flutter/lib/src/screenshot/recorder.dart

@codecov

codecov Bot commented Feb 4, 2025 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.14%. Comparing base (c15867f) to head (d87317f).
Report is 3 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2657      +/-   ##
==========================================
+ Coverage   89.10%   92.14%   +3.03%     
==========================================
  Files         263       90     -173     
  Lines        8943     2928    -6015     
==========================================
- Hits         7969     2698    -5271     
+ Misses        974      230     -744

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vaind vaind changed the title refactor/workaround capture issue refactor: workaround capture issue Feb 4, 2025
@github-actions

github-actions Bot commented Feb 4, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Android Performance metrics 🚀

  Plain With Sentry Diff
Startup time 441.67 ms 515.96 ms 74.28 ms
Size 6.46 MiB 7.48 MiB 1.02 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
72dfc83 298.62 ms 340.14 ms 41.52 ms
a5031f1 379.02 ms 443.12 ms 64.10 ms
547db82 453.40 ms 482.88 ms 29.48 ms
7f14ddd 428.38 ms 511.90 ms 83.51 ms
d0476e1 412.20 ms 492.62 ms 80.42 ms
09c1f55 449.98 ms 509.38 ms 59.40 ms
0118295 365.71 ms 438.56 ms 72.85 ms
22ed6cb 326.27 ms 393.00 ms 66.73 ms
e964e2b 365.15 ms 431.00 ms 65.85 ms
dd25e43 449.40 ms 504.18 ms 54.78 ms

App size

Revision Plain With Sentry Diff
72dfc83 5.94 MiB 6.92 MiB 1001.71 KiB
a5031f1 6.33 MiB 7.29 MiB 987.32 KiB
547db82 6.49 MiB 7.56 MiB 1.07 MiB
7f14ddd 6.35 MiB 7.40 MiB 1.05 MiB
d0476e1 6.35 MiB 7.40 MiB 1.05 MiB
09c1f55 6.49 MiB 7.55 MiB 1.07 MiB
0118295 6.33 MiB 7.26 MiB 947.07 KiB
22ed6cb 6.06 MiB 7.03 MiB 993.37 KiB
e964e2b 6.33 MiB 7.28 MiB 962.81 KiB
dd25e43 6.46 MiB 7.48 MiB 1.02 MiB

Previous results on branch: refactor/workaround-capture-issue

Startup times

Revision Plain With Sentry Diff
984e066 497.74 ms 514.80 ms 17.06 ms
08f18a1 515.46 ms 587.14 ms 71.68 ms
9b96e82 522.02 ms 546.31 ms 24.28 ms

App size

Revision Plain With Sentry Diff
984e066 6.46 MiB 7.48 MiB 1.02 MiB
08f18a1 6.46 MiB 7.48 MiB 1.02 MiB
9b96e82 6.46 MiB 7.48 MiB 1.02 MiB

@github-actions

github-actions Bot commented Feb 4, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

iOS Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1257.29 ms 1270.80 ms 13.51 ms
Size 8.42 MiB 9.91 MiB 1.48 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
9d43f71 1225.06 ms 1227.06 ms 2.00 ms
891efac 1233.78 ms 1248.31 ms 14.53 ms
0028e3e 1242.29 ms 1254.98 ms 12.69 ms
af2d175 1280.37 ms 1282.24 ms 1.88 ms
4d75417 1240.57 ms 1261.76 ms 21.19 ms
bd75526 1252.62 ms 1287.00 ms 34.38 ms
3e4b523 1260.53 ms 1270.06 ms 9.53 ms
e893df5 1247.90 ms 1262.31 ms 14.41 ms
dfcfde9 1238.83 ms 1255.30 ms 16.47 ms
633cf2e 1257.96 ms 1275.73 ms 17.77 ms

App size

Revision Plain With Sentry Diff
9d43f71 8.29 MiB 9.39 MiB 1.10 MiB
891efac 8.28 MiB 9.34 MiB 1.06 MiB
0028e3e 8.42 MiB 9.91 MiB 1.49 MiB
af2d175 8.15 MiB 9.12 MiB 986.22 KiB
4d75417 8.38 MiB 9.71 MiB 1.34 MiB
bd75526 8.38 MiB 9.76 MiB 1.39 MiB
3e4b523 8.28 MiB 9.33 MiB 1.05 MiB
e893df5 8.09 MiB 9.07 MiB 1001.04 KiB
dfcfde9 8.42 MiB 9.91 MiB 1.49 MiB
633cf2e 8.15 MiB 9.12 MiB 986.26 KiB

Previous results on branch: refactor/workaround-capture-issue

Startup times

Revision Plain With Sentry Diff
984e066 1237.58 ms 1247.76 ms 10.17 ms
9b96e82 1259.19 ms 1274.11 ms 14.92 ms
08f18a1 1243.00 ms 1266.26 ms 23.26 ms

App size

Revision Plain With Sentry Diff
984e066 8.42 MiB 9.91 MiB 1.48 MiB
9b96e82 8.42 MiB 9.91 MiB 1.48 MiB
08f18a1 8.42 MiB 9.91 MiB 1.48 MiB

@vaind
vaind marked this pull request as ready for review February 5, 2025 08:52
@vaind
vaind merged commit c6b7cb8 into main Feb 5, 2025
@vaind
vaind deleted the refactor/workaround-capture-issue branch February 5, 2025 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@buenaflor buenaflor buenaflor approved these changes
@krystofwoldrich krystofwoldrich Awaiting requested review from krystofwoldrich
@stefanosiano stefanosiano Awaiting requested review from stefanosiano

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vaind @buenaflor