[v9]: Bump Dart and Flutter version, Dart to 3.5.0, Flutter to 3.24.0 #2643
Merged
Conversation
ueman
reviewed
Jan 29, 2025
# Conflicts: # .github/workflows/dart.yml # dart/test/run_zoned_guarded_integration_test.dart # flutter/lib/src/sentry_asset_bundle.dart # flutter/lib/src/sentry_flutter.dart # flutter/test/screenshot/sentry_screenshot_widget_test.dart
Contributor
🚨 Detected changes in high risk code 🚨High-risk code has higher potential to break the SDK and may be hard to test. To prevent severe bugs, apply the rollout process for releasing such changes and be extra careful when changing and reviewing these files:
|
denrase
marked this pull request as ready for review
January 29, 2025 17:38
denrase
requested review from
buenaflor,
krystofwoldrich and
stefanosiano
as code owners
January 29, 2025 17:38
buenaflor
reviewed
Jan 29, 2025
buenaflor
left a comment
buenaflor
left a comment
Contributor
There was a problem hiding this comment.
looks good on first pass 👍
will have another look later
buenaflor
reviewed
Jan 30, 2025
buenaflor
left a comment
buenaflor
left a comment
Contributor
There was a problem hiding this comment.
we have another library added now link, you can change the versions there too
vaind
requested changes
Jan 30, 2025
Collaborator
|
You can also get rid of this compatibility code: |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## v9 #2643 +/- ##
===========================================
+ Coverage 67.94% 89.17% +21.22%
===========================================
Files 15 263 +248
Lines 443 8924 +8481
===========================================
+ Hits 301 7958 +7657
- Misses 142 966 +824 ☔ View full report in Codecov by Sentry. |
denrase
requested review from
buenaflor and
ueman
and removed request for
buenaflor
February 3, 2025 13:36
vaind
approved these changes
Feb 4, 2025
|
|
||
| ## 9.0.0 | ||
|
|
||
| - Bump Dart and Flutter version, Dart to 3.5.0, Flutter to 3.24.0 ([#2643](https://github.com/getsentry/sentry-dart/pull/2643)) |
Contributor
There was a problem hiding this comment.
Suggested change
| - Bump Dart and Flutter version, Dart to 3.5.0, Flutter to 3.24.0 ([#2643](https://github.com/getsentry/sentry-dart/pull/2643)) | |
| - Increase minimum SDK version requirements to Dart v3.5.0 and Flutter v3.24.0 ([#2643](https://github.com/getsentry/sentry-dart/pull/2643)) |
buenaflor
approved these changes
Feb 4, 2025
6 tasks
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
💡 Motivation and Context
Closes #2626
💚 How did you test it?
CI
📝 Checklist
sendDefaultPiiis enabled