fix: mask sizing on scaling transform widget children#2520
Merged
Conversation
Contributor
🚨 Detected changes in high risk code 🚨High-risk code has higher potential to break the SDK and may be hard to test. To prevent severe bugs, apply the rollout process for releasing such changes and be extra careful when changing and reviewing these files:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2520 +/- ##
==========================================
+ Coverage 87.01% 91.59% +4.57%
==========================================
Files 265 88 -177
Lines 9426 3080 -6346
==========================================
- Hits 8202 2821 -5381
+ Misses 1224 259 -965 ☔ View full report in Codecov by Sentry. |
vaind
marked this pull request as ready for review
December 19, 2024 09:06
vaind
requested review from
buenaflor,
krystofwoldrich and
stefanosiano
as code owners
December 19, 2024 09:06
Contributor
iOS Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 6d50a9b | 1225.69 ms | 1233.94 ms | 8.25 ms |
| 33d0587 | 1262.16 ms | 1270.50 ms | 8.34 ms |
| 9f05645 | 1236.65 ms | 1253.11 ms | 16.45 ms |
| 7f75f32 | 1230.80 ms | 1251.79 ms | 20.99 ms |
| 7f2b01d | 1253.92 ms | 1266.70 ms | 12.78 ms |
| 2b9937e | 1226.27 ms | 1265.18 ms | 38.91 ms |
| a1a1545 | 1270.85 ms | 1289.82 ms | 18.96 ms |
| 4656f10 | 1247.04 ms | 1276.16 ms | 29.12 ms |
| 8d64376 | 1260.92 ms | 1289.32 ms | 28.40 ms |
| 280ab9f | 1255.71 ms | 1262.78 ms | 7.06 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 6d50a9b | 8.38 MiB | 9.74 MiB | 1.36 MiB |
| 33d0587 | 8.29 MiB | 9.38 MiB | 1.09 MiB |
| 9f05645 | 8.28 MiB | 9.34 MiB | 1.06 MiB |
| 7f75f32 | 8.28 MiB | 9.33 MiB | 1.05 MiB |
| 7f2b01d | 8.16 MiB | 9.16 MiB | 1.00 MiB |
| 2b9937e | 8.38 MiB | 9.78 MiB | 1.40 MiB |
| a1a1545 | 8.16 MiB | 9.17 MiB | 1.01 MiB |
| 4656f10 | 8.32 MiB | 9.50 MiB | 1.19 MiB |
| 8d64376 | 8.16 MiB | 9.17 MiB | 1.01 MiB |
| 280ab9f | 8.29 MiB | 9.39 MiB | 1.10 MiB |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
While testing, I've found a situation when there's a
Transformapplied on a widget tree. This would cause the size to be reported smaller than it actually renders on screen(shot). This PR changes how we calculate the bounding box to fix the issue.💡 Motivation and Context
💚 How did you test it?
📝 Checklist
sendDefaultPiiis enabled🔮 Next steps