fix: widget masks overlap when navigating between screens.#2486
Closed
thisames wants to merge 0 commit into
Closed
fix: widget masks overlap when navigating between screens.#2486thisames wants to merge 0 commit into
thisames wants to merge 0 commit into
Conversation
thisames
requested review from
buenaflor,
krystofwoldrich,
martinhaintz and
stefanosiano
as code owners
December 12, 2024 01:03
vaind
requested changes
Dec 12, 2024
vaind
force-pushed
the
fix-mask-overlay-flutter-session-replay
branch
2 times, most recently
from
January 13, 2025 17:34
5d414f2 to
2d34c24
Compare
vaind
approved these changes
Jan 14, 2025
vaind
force-pushed
the
fix-mask-overlay-flutter-session-replay
branch
from
January 14, 2025 12:24
2d34c24 to
ec50b21
Compare
Contributor
|
I've created an in-repo PR so that CI runs completely: #2576 |
Contributor
Author
no problem, good job |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
At first I thought it would be necessary to implement a way to scrape widgets by context, as I did in posthog, but I realized that your code was already correct, it just needs one adjustment.
applying
debugVisitOnstageChildrento your children does exactly what we were looking for. a way to "separate the elements that are hidden and not interactive from the active elements in the current context of the screen"💡 Motivation and Context
widget masks overlap when navigating between screens.
#2309
💚 How did you test it?
I just did several tests with different navigations and applications, checking and debugging the widgets
2024-12-11.21-50-19.mp4
📝 Checklist
sendDefaultPiiis enabled🔮 Next steps