fix: masking semi-transparent widgets#2472
Merged
Merged
Conversation
Contributor
🚨 Detected changes in high risk code 🚨High-risk code has higher potential to break the SDK and may be hard to test. To prevent severe bugs, apply the rollout process for releasing such changes and be extra careful when changing and reviewing these files:
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2472 +/- ##
==========================================
+ Coverage 84.23% 91.38% +7.15%
==========================================
Files 181 87 -94
Lines 6514 3031 -3483
==========================================
- Hits 5487 2770 -2717
+ Misses 1027 261 -766 ☔ View full report in Codecov by Sentry. |
Contributor
Android Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 64af39c | 386.80 ms | 471.11 ms | 84.31 ms |
| 1d47eb7 | 282.26 ms | 342.52 ms | 60.26 ms |
| b728df4 | 390.98 ms | 445.81 ms | 54.83 ms |
| 7273303 | 415.33 ms | 491.51 ms | 76.18 ms |
| 50bdfad | 395.22 ms | 461.21 ms | 65.98 ms |
| 13f8952 | 459.41 ms | 500.16 ms | 40.76 ms |
| 559d28f | 302.35 ms | 339.53 ms | 37.18 ms |
| 04db237 | 330.16 ms | 428.38 ms | 98.22 ms |
| ef2f368 | 350.06 ms | 429.44 ms | 79.38 ms |
| bffc2c5 | 348.00 ms | 399.89 ms | 51.89 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 64af39c | 6.27 MiB | 7.20 MiB | 958.83 KiB |
| 1d47eb7 | 6.16 MiB | 7.14 MiB | 1010.29 KiB |
| b728df4 | 5.94 MiB | 6.95 MiB | 1.01 MiB |
| 7273303 | 6.34 MiB | 7.29 MiB | 970.36 KiB |
| 50bdfad | 6.33 MiB | 7.30 MiB | 987.47 KiB |
| 13f8952 | 6.49 MiB | 7.56 MiB | 1.08 MiB |
| 559d28f | 5.94 MiB | 6.92 MiB | 1001.70 KiB |
| 04db237 | 5.94 MiB | 6.95 MiB | 1.01 MiB |
| ef2f368 | 5.94 MiB | 6.89 MiB | 975.81 KiB |
| bffc2c5 | 6.34 MiB | 7.28 MiB | 966.31 KiB |
Contributor
iOS Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 8a10ab7 | 1226.49 ms | 1250.52 ms | 24.03 ms |
| 0be962b | 1264.10 ms | 1281.16 ms | 17.06 ms |
| ef2f368 | 1259.12 ms | 1277.04 ms | 17.92 ms |
| 7ec9238 | 1259.69 ms | 1281.59 ms | 21.90 ms |
| 89ea268 | 1252.33 ms | 1253.58 ms | 1.26 ms |
| 6e083bb | 1244.33 ms | 1264.60 ms | 20.26 ms |
| 1bbb79f | 1242.17 ms | 1264.39 ms | 22.21 ms |
| dd933d4 | 1238.73 ms | 1252.43 ms | 13.70 ms |
| e3d9076 | 1203.68 ms | 1230.65 ms | 26.97 ms |
| a094100 | 1260.27 ms | 1276.75 ms | 16.48 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 8a10ab7 | 8.28 MiB | 9.34 MiB | 1.06 MiB |
| 0be962b | 8.10 MiB | 9.16 MiB | 1.07 MiB |
| ef2f368 | 8.15 MiB | 9.10 MiB | 965.24 KiB |
| 7ec9238 | 8.34 MiB | 9.65 MiB | 1.31 MiB |
| 89ea268 | 8.09 MiB | 9.16 MiB | 1.06 MiB |
| 6e083bb | 8.16 MiB | 9.17 MiB | 1.01 MiB |
| 1bbb79f | 8.38 MiB | 9.78 MiB | 1.40 MiB |
| dd933d4 | 8.33 MiB | 9.64 MiB | 1.31 MiB |
| e3d9076 | 8.33 MiB | 9.40 MiB | 1.07 MiB |
| a094100 | 8.16 MiB | 9.17 MiB | 1.01 MiB |
This was referenced Dec 10, 2024
vaind
marked this pull request as ready for review
December 10, 2024 10:01
vaind
requested review from
buenaflor,
krystofwoldrich,
martinhaintz and
stefanosiano
as code owners
December 10, 2024 10:01
buenaflor
approved these changes
Dec 10, 2024
| }); | ||
|
|
||
| if (result == null) { | ||
| int limit = 20; |
Contributor
There was a problem hiding this comment.
I assume 20 is an arbitrary number right?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
💡 Motivation and Context
closes #2454
💚 How did you test it?
📝 Checklist
sendDefaultPiiis enabled🔮 Next steps