Validation for fetchedDisplayRefreshRate#2299
Closed
Volsavr wants to merge 2 commits into
Closed
Conversation
Volsavr
requested review from
buenaflor,
krystofwoldrich and
stefanosiano
as code owners
September 19, 2024 08:06
Contributor
|
Hi @Volsavr thanks for opening the PR! |
Contributor
|
I don't think we should set it to a default refresh rate. a couple weeks ago we decided that we want to keep this accurate or not do it so if we can't return a proper refresh rate it should just disable the instrumentation instead of applying a default rate I can prepare a PR for fixing that |
6 tasks
Contributor
|
We have added validations here #2307 |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
Additional validation for displayRefreshRate received from the native level.
💡 Motivation and Context
We noticed that following code:
final fetchedDisplayRefreshRate = await _native?.displayRefreshRate();sometimes returns 0. It happens only on macOS Monterey and below (At least in our cases).
Assigning 0 to fetchedDisplayRefreshRate leads to exception:
Unsupported operation: Infinity or NaN toInt #0 SpanFrameMetricsCollector.calculateFrameMetrics (package:sentry_flutter/src/span_frame_metrics_collector.dart) #1 SpanFrameMetricsCollector.onSpanFinished (package:sentry_flutter/src/span_frame_metrics_collector.dart:80) #2 SentrySpan.finish (package:sentry/src/protocol/sentry_span.dart:81) #3 SentryTracer.finish (package:sentry/src/sentry_tracer.dart:139) #4 SentryTracer._finishedCallback (package:sentry/src/sentry_tracer.dart:282) #5 SentrySpan.finish (package:sentry/src/protocol/sentry_span.dart:94)Also it may lead to ui issues in the app (we faced with issues related to displaying svg resources).
💚 How did you test it?
Using default displayRefreshRate (60) prevents exception appearing and ui issues.
📝 Checklist
sendDefaultPiiis enabled