Skip to content

CI: Fix CI when running tests on chrome platform that hangs if using coverage - #227

Merged
marandaneto merged 1 commit into
mainfrom
fix/coverage-hangs
Dec 6, 2020
Merged

marandaneto merged 1 commit into
mainfrom
fix/coverage-hangs

Conversation

@marandaneto

@marandaneto marandaneto commented Dec 6, 2020 •

Copy link
Copy Markdown
Contributor

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

CI: Fix CI when running tests on chrome platform that hangs if using coverage

💡 Motivation and Context

command hangs and CI consequentially never finishes.
I could reproduce this locally as well, only happens if coverage is enabled and running on chrome platform as well.

💚 How did you test it?

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • All tests passing
  • No breaking changes

🔮 Next steps

wait for help
dart-lang/tools#471

@marandaneto marandaneto mentioned this pull request Dec 6, 2020
5 of 8 tasks
@codecov-io

Copy link
Copy Markdown

Codecov Report

Merging #227 (c789414) into main (6193daf) will decrease coverage by 2.10%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     dart-lang/tools#445      +/-   ##
==========================================
- Coverage   82.79%   80.68%   -2.11%     
==========================================
  Files           6       51      +45     
  Lines         215     1579    +1364     
==========================================
+ Hits          178     1274    +1096     
- Misses         37      305     +268     
Impacted Files Coverage Δ
dart/lib/src/hub.dart 64.83% <0.00%> (ø)
dart/lib/src/protocol/sentry_package.dart 83.33% <0.00%> (ø)
dart/lib/src/protocol/gpu.dart 82.92% <0.00%> (ø)
dart/lib/src/protocol/dsn.dart 90.47% <0.00%> (ø)
dart/lib/src/protocol/breadcrumb.dart 86.66% <0.00%> (ø)
dart/lib/src/transport/http_transport.dart 92.30% <0.00%> (ø)
dart/lib/src/throwable_mechanism.dart 100.00% <0.00%> (ø)
dart/lib/src/protocol/request.dart 46.51% <0.00%> (ø)
dart/lib/src/protocol/sentry_stack_frame.dart 87.14% <0.00%> (ø)
dart/lib/src/protocol/debug_image.dart 61.29% <0.00%> (ø)
... and 35 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6193daf...c789414. Read the comment docs.

@marandaneto marandaneto changed the title CI: Fix tests on chrome that hangs if using coverage CI: Fix CI when running tests on chrome platform that hangs if using coverage Dec 6, 2020
@marandaneto
marandaneto merged commit e45daae into main Dec 6, 2020
@marandaneto
marandaneto deleted the fix/coverage-hangs branch December 6, 2020 10:08
ueman pushed a commit to ueman/sentry-dart that referenced this pull request Dec 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants