Generated by 🚫 dangerJS against 48bc130

Codecov Report

Attention: Patch coverage is 92.48555% with 13 lines in your changes missing coverage. Please review.

Project coverage is 85.08%. Comparing base (c3fc461) to head (48bc130).
Report is 3 commits behind head on main.

@@            Coverage Diff             @@
##             main    #2230      +/-   ##
==========================================
+ Coverage   84.43%   85.08%   +0.64%     
==========================================
  Files         248      241       -7     
  Lines        8811     8751      -60     
==========================================
+ Hits         7440     7446       +6     
+ Misses       1371     1305      -66     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

iOS Performance metrics 🚀

I'm really looking forward to this, to use it in https://pub.dev/packages/feedback Thanks for tackling it!

@ueman on a side note, after this PR we are also looking into implementing the feedback widget

maybe it makes sense to adopt some code from your package? but let's see I haven't taken a deep dive yet into that

@buenaflor I'm not sure if i have all the pieces in place that we need, would you mind taking a quick look over it and giving me feedback? /cc ueman

@ueman on a side note, after this PR we are also looking into implementing the feedback widget

maybe it makes sense to adopt some code from your package? but let's see I haven't taken a deep dive yet into that

I would advise against using my package, at least as of know, as there are a couple of fundamental issues with it, that would require a lot of effort to fix. I would love to see those fixed though.

As for the (Sentry) feedback widget, there's already a very simple but working implementation at https://github.com/getsentry/sentry-dart/blob/main/flutter/example/lib/user_feedback_dialog.dart

With a bit of polishing (mainly around handling issues during sending the feedback, maybe UI adjustments), it should be quite easy to ship.

@buenaflor I'm not sure if i have all the pieces in place that we need, would you mind taking a quick look over it and giving me feedback? /cc ueman

Unfortunately, I also already failed once to implement this spec. So I'm afraid I can't really help here :/

Ok, i can see the new feedback on sentry.io \o/

Seems to work fine on iOS, macOS and web. On Android i can see the envelope in Spotlight, but no new issue is appearing on sentry.io.

Android Performance metrics 🚀

@aliu39 we believe its most likely an SDK internal issue, we'll investigate it

@buenaflor Waiting for getsentry/sentry-java#3687

@buenaflor getsentry/sentry-java#3687 was merged. Waiting for it beeing released, then we can finish here.

Can't this be already merged? I mean the code works, and the Android dependency will be updated anyway as soon as it's release right?

@ueman Think we could, but then we'd potentially block releases if Android takes longer than expected, no?

@buenaflor What do you think? Should we merge this with the info that Android support will come later? Would be easier, as i have to merge in main every other day and fixing issues that arise.

@denrase I'll do a release soon, either today or tomorrow, we can merge it afterwards so we can wait for the android release

just tested and android works fine after bumping to Android 7.15.0👍

will merge after tests are green