Add api for pausing/resuming cocoa app hang tracking#2134
Merged
Conversation
Contributor
Instructions and example for changelogPlease add an entry to Example: ## Unreleased
- Add api for pausing/resuming cocoa app hang tracking ([#2134](https://github.com/getsentry/sentry-dart/pull/2134))If none of the above apply, you can opt out of this check by adding |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2134 +/- ##
==========================================
+ Coverage 88.41% 91.99% +3.58%
==========================================
Files 224 62 -162
Lines 7705 2036 -5669
==========================================
- Hits 6812 1873 -4939
+ Misses 893 163 -730 ☔ View full report in Codecov by Sentry. |
Contributor
Android Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 56810ff | 309.72 ms | 352.26 ms | 42.54 ms |
| 3e33891 | 313.60 ms | 379.51 ms | 65.91 ms |
| fe4aa56 | 356.06 ms | 428.67 ms | 72.61 ms |
| 8cb6557 | 321.20 ms | 370.46 ms | 49.26 ms |
| a510d1d | 295.63 ms | 344.65 ms | 49.03 ms |
| f275487 | 369.08 ms | 432.44 ms | 63.36 ms |
| 689d2fd | 378.62 ms | 430.48 ms | 51.86 ms |
| 746a779 | 347.94 ms | 385.71 ms | 37.78 ms |
| d189e01 | 328.67 ms | 397.12 ms | 68.45 ms |
| 5603ab2 | 309.84 ms | 345.20 ms | 35.36 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 56810ff | 5.94 MiB | 6.92 MiB | 1001.71 KiB |
| 3e33891 | 6.16 MiB | 7.14 MiB | 1007.46 KiB |
| fe4aa56 | 6.06 MiB | 7.10 MiB | 1.04 MiB |
| 8cb6557 | 6.06 MiB | 7.03 MiB | 997.01 KiB |
| a510d1d | 5.94 MiB | 6.96 MiB | 1.02 MiB |
| f275487 | 6.33 MiB | 7.26 MiB | 947.03 KiB |
| 689d2fd | 6.06 MiB | 7.10 MiB | 1.04 MiB |
| 746a779 | 6.27 MiB | 7.20 MiB | 956.05 KiB |
| d189e01 | 6.16 MiB | 7.14 MiB | 1009.90 KiB |
| 5603ab2 | 5.94 MiB | 6.95 MiB | 1.01 MiB |
Contributor
iOS Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 7273303 | 1246.50 ms | 1262.06 ms | 15.56 ms |
| 3a43905 | 1254.31 ms | 1266.35 ms | 12.04 ms |
| be8cafe | 1239.94 ms | 1266.20 ms | 26.27 ms |
| f96ca24 | 1264.39 ms | 1287.98 ms | 23.59 ms |
| 26e955b | 1232.35 ms | 1258.88 ms | 26.52 ms |
| 4b943a1 | 1250.23 ms | 1262.28 ms | 12.05 ms |
| d61cecf | 1276.96 ms | 1290.02 ms | 13.06 ms |
| 683fd34 | 1239.83 ms | 1259.08 ms | 19.25 ms |
| e66e71e | 1273.55 ms | 1291.63 ms | 18.08 ms |
| c73ab67 | 1267.73 ms | 1279.36 ms | 11.63 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 7273303 | 8.33 MiB | 9.40 MiB | 1.07 MiB |
| 3a43905 | 8.10 MiB | 9.18 MiB | 1.08 MiB |
| be8cafe | 8.33 MiB | 9.40 MiB | 1.07 MiB |
| f96ca24 | 8.10 MiB | 9.08 MiB | 1004.36 KiB |
| 26e955b | 8.28 MiB | 9.34 MiB | 1.05 MiB |
| 4b943a1 | 8.33 MiB | 9.40 MiB | 1.07 MiB |
| d61cecf | 8.10 MiB | 9.18 MiB | 1.08 MiB |
| 683fd34 | 8.28 MiB | 9.34 MiB | 1.06 MiB |
| e66e71e | 8.10 MiB | 9.08 MiB | 1004.36 KiB |
| c73ab67 | 8.29 MiB | 9.36 MiB | 1.07 MiB |
buenaflor
marked this pull request as ready for review
June 26, 2024 11:11
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
Allows users to control the app hang tracking.
This might be important to prevent the Cocoa SDK from reporting wrongly detected app hangs when the OS shows a system dialog for asking specific permissions.
💡 Motivation and Context
Closes #2116
💚 How did you test it?
Unit tests
📝 Checklist
sendDefaultPiiis enabled🔮 Next steps