Set snapshot to true#2000
Merged
Merged
Conversation
ueman
requested review from
buenaflor,
krystofwoldrich and
stefanosiano
as code owners
April 19, 2024 11:12
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2000 +/- ##
==========================================
- Coverage 88.57% 87.57% -1.00%
==========================================
Files 207 154 -53
Lines 6897 4998 -1899
==========================================
- Hits 6109 4377 -1732
+ Misses 788 621 -167 ☔ View full report in Codecov by Sentry. |
Collaborator
Author
|
The test failure is due to a cancellation. I unfortunately can't rerun it tho. I think other than that this should be good to go |
Contributor
|
yeah, the macos runner is pretty slow and times out after 30mins |
buenaflor
approved these changes
Apr 24, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
Fixes #1879
💡 Motivation and Context
💚 How did you test it?
Manually & new test
📝 Checklist
sendDefaultPiiis enabled🔮 Next steps
Where am I now supposed to put the changelog?