Exception aggregate mechanism#1866
Merged
Merged
Conversation
ueman
requested review from
buenaflor,
krystofwoldrich and
stefanosiano
as code owners
February 5, 2024 18:31
ueman
commented
Feb 5, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release/8.0.0 #1866 +/- ##
===============================================
Coverage 88.55% 88.55%
===============================================
Files 205 218 +13
Lines 6884 7522 +638
===============================================
+ Hits 6096 6661 +565
- Misses 788 861 +73 ☔ View full report in Codecov by Sentry. |
buenaflor
approved these changes
Feb 6, 2024
Contributor
|
some tests are still failing it looks like |
Collaborator
Author
|
@buenaflor |
Contributor
|
|
ueman
commented
Feb 14, 2024
Collaborator
Author
|
@buenaflor Is there something I still need to do here? As far as I can tell, the remaining failing jobs aren't related to this PR. |
Contributor
|
I'll merge main into v8 soon and the ci should be green then |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
Adds the new field according to https://github.com/getsentry/rfcs/blob/main/text/0079-exception-groups.md#new-mechanism-fields
I didn't yet implement exception aggregates for anything. That can be done in follow-up PRs.
The current CI failures are due to targeting the v8 branch, I believe. At least, I can't see any failures related to the new code.
💡 Motivation and Context
https://github.com/getsentry/rfcs/blob/main/text/0079-exception-groups.md
A tiny step towards #1859
💚 How did you test it?
Updated tests
📝 Checklist
sendDefaultPiiis enabled🔮 Next steps
Use it for PlatformException in the Flutter code.
#skip-changelog