Skip to content

Check if the Native SDKs are enabled when using autoInitializeNativeSdk false#1489

Merged
marandaneto merged 2 commits into
mainfrom
fix/autoInitializeNativeSdk-disabled
May 30, 2023
Merged

Check if the Native SDKs are enabled when using autoInitializeNativeSdk false#1489
marandaneto merged 2 commits into
mainfrom
fix/autoInitializeNativeSdk-disabled

Conversation

@marandaneto

@marandaneto marandaneto commented May 26, 2023

Copy link
Copy Markdown
Contributor

📜 Description

Check if the Native SDKs are enabled when using autoInitializeNativeSdk=false

💡 Motivation and Context

Relates to #1486

💚 How did you test it?

Running autoInitializeNativeSdk mode and checking logs.

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPii is enabled
  • I updated the docs if needed
  • All tests passing
  • No breaking changes

🔮 Next steps

marandaneto
marandaneto commented May 26, 2023
View reviewed changes
Comment thread flutter/android/src/main/kotlin/io/sentry/flutter/SentryFlutterPlugin.kt
@marandaneto

marandaneto commented May 26, 2023

Copy link
Copy Markdown
Contributor Author

@krystofwoldrich this might be useful for RN as well.

@marandaneto marandaneto mentioned this pull request May 26, 2023
Closed
@codecov

codecov Bot commented May 26, 2023 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Patch and project coverage have no change.

Comparison is base (86d4841) 90.18% compared to head (288b11f) 90.18%.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1489   +/-   ##
=======================================
  Coverage   90.18%   90.18%           
=======================================
  Files         181      181           
  Lines        5776     5776           
=======================================
  Hits         5209     5209           
  Misses        567      567

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions

github-actions Bot commented May 26, 2023

Copy link
Copy Markdown
Contributor

Android Performance metrics 🚀

  Plain With Sentry Diff
Startup time 317.44 ms 401.69 ms 84.25 ms
Size 6.15 MiB 7.13 MiB 1000.43 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
457a85b 312.37 ms 376.67 ms 64.31 ms
1c6eb5b 350.69 ms 393.86 ms 43.17 ms
8a7f528 290.27 ms 341.80 ms 51.53 ms
abcdba3 354.68 ms 399.04 ms 44.36 ms
a609134 350.12 ms 404.12 ms 54.00 ms
62dde43 339.21 ms 423.06 ms 83.85 ms
0db91cc 327.85 ms 387.31 ms 59.46 ms
559d28f 302.35 ms 339.53 ms 37.18 ms
0a82a1e 321.02 ms 393.82 ms 72.80 ms
fe4aa56 356.06 ms 428.67 ms 72.61 ms

App size

Revision Plain With Sentry Diff
457a85b 6.06 MiB 7.09 MiB 1.03 MiB
1c6eb5b 5.94 MiB 6.92 MiB 1001.53 KiB
8a7f528 6.06 MiB 7.03 MiB 989.36 KiB
abcdba3 5.94 MiB 6.95 MiB 1.01 MiB
a609134 5.94 MiB 6.95 MiB 1.01 MiB
62dde43 5.94 MiB 6.96 MiB 1.02 MiB
0db91cc 5.94 MiB 6.95 MiB 1.01 MiB
559d28f 5.94 MiB 6.92 MiB 1001.70 KiB
0a82a1e 6.15 MiB 7.11 MiB 981.82 KiB
fe4aa56 6.06 MiB 7.10 MiB 1.04 MiB

@github-actions

github-actions Bot commented May 26, 2023

Copy link
Copy Markdown
Contributor

iOS Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1221.67 ms 1232.08 ms 10.41 ms
Size 8.29 MiB 9.36 MiB 1.07 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
8e133ad 1268.19 ms 1277.37 ms 9.18 ms
aed5947 1268.67 ms 1281.10 ms 12.43 ms
e893df5 1247.90 ms 1262.31 ms 14.41 ms
40680d3 1243.22 ms 1257.02 ms 13.80 ms
3a43905 1254.31 ms 1266.35 ms 12.04 ms
ef2f368 1259.12 ms 1277.04 ms 17.92 ms
8ced2dc 1258.35 ms 1272.98 ms 14.62 ms
3a69405 1292.84 ms 1303.96 ms 11.12 ms
dd1f7d2 1263.16 ms 1275.15 ms 11.99 ms
519423f 1240.80 ms 1260.88 ms 20.08 ms

App size

Revision Plain With Sentry Diff
8e133ad 8.10 MiB 9.16 MiB 1.07 MiB
aed5947 8.16 MiB 9.17 MiB 1.01 MiB
e893df5 8.09 MiB 9.07 MiB 1001.04 KiB
40680d3 8.10 MiB 9.16 MiB 1.07 MiB
3a43905 8.10 MiB 9.18 MiB 1.08 MiB
ef2f368 8.15 MiB 9.10 MiB 965.24 KiB
8ced2dc 8.10 MiB 9.16 MiB 1.07 MiB
3a69405 8.15 MiB 9.15 MiB 1018.56 KiB
dd1f7d2 8.10 MiB 9.16 MiB 1.07 MiB
519423f 8.10 MiB 9.16 MiB 1.06 MiB

@marandaneto
marandaneto marked this pull request as ready for review May 26, 2023 08:44
@marandaneto
marandaneto merged commit 4992df7 into main May 30, 2023
@marandaneto
marandaneto deleted the fix/autoInitializeNativeSdk-disabled branch May 30, 2023 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@krystofwoldrich krystofwoldrich Awaiting requested review from krystofwoldrich
2 more reviewers
@brustolin brustolin brustolin left review comments
@stefanosiano stefanosiano stefanosiano approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@marandaneto @stefanosiano @brustolin