Support http lib v1.0.0#1475
Merged
Merged
Conversation
marandaneto
requested review from
krystofwoldrich and
stefanosiano
as code owners
May 23, 2023 09:16
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #1475 +/- ##
=======================================
Coverage 90.20% 90.20%
=======================================
Files 181 181
Lines 5788 5788
=======================================
Hits 5221 5221
Misses 567 567 ☔ View full report in Codecov by Sentry. |
Contributor
Android Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| b49bf00 | 323.46 ms | 375.35 ms | 51.89 ms |
| 1b66358 | 314.96 ms | 363.39 ms | 48.43 ms |
| af2d175 | 279.08 ms | 312.37 ms | 33.29 ms |
| 7f2b01d | 304.94 ms | 345.71 ms | 40.78 ms |
| 4efee31 | 308.92 ms | 368.68 ms | 59.76 ms |
| 90db9ff | 334.86 ms | 388.14 ms | 53.28 ms |
| 8d64376 | 302.88 ms | 356.84 ms | 53.96 ms |
| aa950e9 | 337.42 ms | 400.72 ms | 63.30 ms |
| 6e083bb | 327.96 ms | 381.39 ms | 53.43 ms |
| 1131914 | 317.90 ms | 361.58 ms | 43.69 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| b49bf00 | 6.06 MiB | 7.10 MiB | 1.04 MiB |
| 1b66358 | 6.06 MiB | 7.09 MiB | 1.03 MiB |
| af2d175 | 5.94 MiB | 6.92 MiB | 1001.83 KiB |
| 7f2b01d | 5.94 MiB | 6.95 MiB | 1.01 MiB |
| 4efee31 | 5.94 MiB | 6.92 MiB | 1003.76 KiB |
| 90db9ff | 6.06 MiB | 7.10 MiB | 1.04 MiB |
| 8d64376 | 5.94 MiB | 6.96 MiB | 1.02 MiB |
| aa950e9 | 5.94 MiB | 6.96 MiB | 1.02 MiB |
| 6e083bb | 5.94 MiB | 6.97 MiB | 1.03 MiB |
| 1131914 | 5.94 MiB | 6.96 MiB | 1.02 MiB |
kuhnroyal
approved these changes
May 23, 2023
stefanosiano
approved these changes
May 23, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
Bump version constraint https://pub.dev/packages/http
💡 Motivation and Context
Closes #1474
💚 How did you test it?
📝 Checklist
sendDefaultPiiis enabled🔮 Next steps