Avoid dependency conflict with package_info_plus v4 by marandaneto · Pull Request #1440 · getsentry/sentry-dart

marandaneto · 2023-05-12T07:31:41Z

📜 Description

Avoid dependency conflict with package_info_plus v4

💡 Motivation and Context

https://docs.flutter.dev/reference/supported-platforms#deploying-flutter

💚 How did you test it?

CI should be green

📝 Checklist

I reviewed submitted code
I added tests to verify changes
No new PII added or SDK only sends newly added PII if sendDefaultPii is enabled
I updated the docs if needed
All tests passing
No breaking changes

🔮 Next steps

Document breaking change under sentry docs.

codecov · 2023-05-12T07:34:13Z

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.59 ⚠️

Comparison is base (bf4aed7) 90.79% compared to head (cc803a1) 90.20%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1440      +/-   ##
==========================================
- Coverage   90.79%   90.20%   -0.59%     
==========================================
  Files          61      181     +120     
  Lines        2042     5789    +3747     
==========================================
+ Hits         1854     5222    +3368     
- Misses        188      567     +379

Impacted Files	Coverage Δ
...nt_processor/flutter_enricher_event_processor.dart	`94.18% <ø> (ø)`
...rc/event_processor/screenshot_event_processor.dart	`79.48% <ø> (ø)`
...ter/lib/src/view_hierarchy/sentry_tree_walker.dart	`100.00% <ø> (ø)`
flutter/lib/src/widgets_binding_observer.dart	`98.21% <ø> (ø)`
dart/lib/src/run_zoned_guarded_integration.dart	`69.69% <100.00%> (ø)`
dart/lib/src/sentry_isolate.dart	`100.00% <100.00%> (ø)`
...ib/src/integrations/flutter_error_integration.dart	`100.00% <100.00%> (ø)`
...ter/lib/src/integrations/on_error_integration.dart	`94.28% <100.00%> (ø)`

... and 118 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

github-actions · 2023-05-12T08:08:21Z

iOS Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	1261.14 ms	1281.04 ms	19.90 ms
Size	8.10 MiB	9.18 MiB	1.08 MiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`6957bfd`	1283.80 ms	1289.00 ms	5.20 ms
`c1bb00f`	1265.14 ms	1290.85 ms	25.71 ms
`a49594a`	1284.83 ms	1313.29 ms	28.45 ms
`211a7aa`	1258.02 ms	1275.65 ms	17.63 ms
`457a85b`	1275.17 ms	1285.51 ms	10.34 ms
`aed5947`	1268.67 ms	1281.10 ms	12.43 ms
`8e133ad`	1268.19 ms	1277.37 ms	9.18 ms
`873fb42`	1261.00 ms	1285.92 ms	24.92 ms
`90db9ff`	1277.18 ms	1283.69 ms	6.51 ms
`2f8f173`	1280.61 ms	1292.20 ms	11.59 ms

App size

Revision	Plain	With Sentry	Diff
`6957bfd`	8.15 MiB	9.15 MiB	1020.71 KiB
`c1bb00f`	8.09 MiB	9.07 MiB	1001.06 KiB
`a49594a`	8.16 MiB	9.16 MiB	1.00 MiB
`211a7aa`	8.10 MiB	9.18 MiB	1.08 MiB
`457a85b`	8.09 MiB	9.07 MiB	1000.88 KiB
`aed5947`	8.16 MiB	9.17 MiB	1.01 MiB
`8e133ad`	8.10 MiB	9.16 MiB	1.07 MiB
`873fb42`	8.16 MiB	9.17 MiB	1.01 MiB
`90db9ff`	8.10 MiB	9.08 MiB	1004.27 KiB
`2f8f173`	8.15 MiB	9.13 MiB	1000.39 KiB

Previous results on branch: chore/package_info_v4

Startup times

Revision	Plain	With Sentry	Diff
`b89812e`	1279.98 ms	1290.24 ms	10.27 ms

App size

Revision	Plain	With Sentry	Diff
`b89812e`	8.10 MiB	9.18 MiB	1.08 MiB

marandaneto · 2023-05-12T12:28:33Z

@krystofwoldrich @stefanosiano mind reviewing this one quickly? it's blocking some other PRs.

krystofwoldrich

@marandaneto The metrics app still needs a bum to A SDK v19.

Do I get it right, that our SDK will actually work on A SDK v16 with older Flutter? But we can test it anymore since we build in CI with the latest Flutter version.

marandaneto · 2023-05-13T06:24:10Z

@marandaneto The metrics app still needs a bum to A SDK v19.

Do I get it right, that our SDK will actually work on A SDK v16 with older Flutter? But we can test it anymore since we build in CI with the latest Flutter version.

Good catch, b89812e

github-actions · 2023-05-13T06:36:01Z

Android Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	312.10 ms	385.14 ms	73.04 ms
Size	6.06 MiB	7.04 MiB	998.28 KiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`e5b744f`	302.70 ms	342.17 ms	39.47 ms
`ecb4003`	332.58 ms	385.15 ms	52.57 ms
`e2d89fc`	323.84 ms	376.23 ms	52.39 ms
`895becc`	326.94 ms	376.02 ms	49.08 ms
`7ade5af`	341.04 ms	386.84 ms	45.80 ms
`0a23f98`	377.19 ms	416.18 ms	39.00 ms
`3a69405`	334.34 ms	369.19 ms	34.85 ms
`ad69abc`	297.35 ms	385.89 ms	88.54 ms
`9f9f94f`	331.04 ms	368.92 ms	37.88 ms
`deaeece`	347.42 ms	381.10 ms	33.68 ms

App size

Revision	Plain	With Sentry	Diff
`e5b744f`	6.06 MiB	7.09 MiB	1.03 MiB
`ecb4003`	6.06 MiB	7.09 MiB	1.03 MiB
`e2d89fc`	6.06 MiB	7.03 MiB	989.37 KiB
`895becc`	6.06 MiB	7.03 MiB	997.23 KiB
`7ade5af`	5.94 MiB	6.95 MiB	1.01 MiB
`0a23f98`	6.06 MiB	7.03 MiB	996.97 KiB
`3a69405`	5.94 MiB	6.95 MiB	1.01 MiB
`ad69abc`	6.06 MiB	7.09 MiB	1.03 MiB
`9f9f94f`	5.94 MiB	6.95 MiB	1.01 MiB
`deaeece`	5.94 MiB	6.96 MiB	1.02 MiB

Previous results on branch: chore/package_info_v4

Startup times

Revision	Plain	With Sentry	Diff
`b89812e`	357.56 ms	431.33 ms	73.77 ms

App size

Revision	Plain	With Sentry	Diff
`b89812e`	6.06 MiB	7.04 MiB	998.28 KiB

marandaneto · 2023-05-15T07:10:43Z

@marandaneto The metrics app still needs a bum to A SDK v19.

Do I get it right, that our SDK will actually work on A SDK v16 with older Flutter? But we can test it anymore since we build in CI with the latest Flutter version.

Android SDK is min 14, but Flutter was 16 and now is 19.

krystofwoldrich

🚀

krystofwoldrich

🚀

marandaneto and others added 3 commits May 12, 2023 09:31

Avoid dependency conflict with package_info_plus v4

cab67fe

pr id

93287a1

Format & fix code

7b46a72

marandaneto marked this pull request as ready for review May 12, 2023 07:33

marandaneto requested review from krystofwoldrich and stefanosiano as code owners May 12, 2023 07:33

Format & fix code

50602a5

marandaneto closed this May 12, 2023

marandaneto reopened this May 12, 2023

getsentry-bot added 2 commits May 12, 2023 07:39

Format & fix code

d4f7fca

Format & fix code

8c6a518

marandaneto closed this May 12, 2023

marandaneto reopened this May 12, 2023

marandaneto added 2 commits May 12, 2023 09:46

fix

aea0b81

fix

d1f418d

ThexXTURBOXx mentioned this pull request May 12, 2023

Support package_info_plus 4.x #1436

Closed

6 tasks

marandaneto added 6 commits May 12, 2023 10:12

ignore deprecated fields

4b69767

fix

480a929

fix

69e2d60

fix

1c3ec98

fix

aa26874

fix comments indentation

3bdd7fa

marandaneto mentioned this pull request May 12, 2023

sentry_flutter 7.5.2 incompatible with package_info_plus 4.0.0 #1442

Closed

fix

1b7e423

This comment was marked as outdated.

Sign in to view

krystofwoldrich suggested changes May 12, 2023

View reviewed changes

fix

b89812e

close sdk

cc803a1

marandaneto requested a review from krystofwoldrich May 15, 2023 07:09

krystofwoldrich approved these changes May 15, 2023

View reviewed changes

marandaneto merged commit 801068d into main May 15, 2023

marandaneto deleted the chore/package_info_v4 branch May 15, 2023 08:20

marandaneto mentioned this pull request May 16, 2023

Sentry_flutter package is Incompatible with package_info_plus ^4.0.0 #1453

Closed

Uh oh!

Uh oh!

Conversation

marandaneto commented May 12, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📜 Description

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

🔮 Next steps

Uh oh!

codecov Bot commented May 12, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

github-actions Bot commented May 12, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

iOS Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

Previous results on branch: chore/package_info_v4

Startup times

App size

Uh oh!

marandaneto commented May 12, 2023

Uh oh!

This comment was marked as outdated.

Uh oh!

krystofwoldrich left a comment

Choose a reason for hiding this comment

Uh oh!

marandaneto commented May 13, 2023

Uh oh!

github-actions Bot commented May 13, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Android Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

Previous results on branch: chore/package_info_v4

Startup times

App size

Uh oh!

marandaneto commented May 15, 2023

Uh oh!

krystofwoldrich left a comment

Choose a reason for hiding this comment

Uh oh!

krystofwoldrich left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

marandaneto commented May 12, 2023 •

edited

Loading

codecov Bot commented May 12, 2023 •

edited

Loading

github-actions Bot commented May 12, 2023 •

edited

Loading

github-actions Bot commented May 13, 2023 •

edited

Loading