Deprecate extra in favor of contexts#1435
Conversation
|
Change the target branch to |
marandaneto
changed the title
Android Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| e5b744f | 302.70 ms | 342.17 ms | 39.47 ms |
| ecb4003 | 332.58 ms | 385.15 ms | 52.57 ms |
| e2d89fc | 323.84 ms | 376.23 ms | 52.39 ms |
| 895becc | 326.94 ms | 376.02 ms | 49.08 ms |
| 7ade5af | 341.04 ms | 386.84 ms | 45.80 ms |
| 0a23f98 | 377.19 ms | 416.18 ms | 39.00 ms |
| 3a69405 | 334.34 ms | 369.19 ms | 34.85 ms |
| ad69abc | 297.35 ms | 385.89 ms | 88.54 ms |
| 9f9f94f | 331.04 ms | 368.92 ms | 37.88 ms |
| deaeece | 347.42 ms | 381.10 ms | 33.68 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| e5b744f | 6.06 MiB | 7.09 MiB | 1.03 MiB |
| ecb4003 | 6.06 MiB | 7.09 MiB | 1.03 MiB |
| e2d89fc | 6.06 MiB | 7.03 MiB | 989.37 KiB |
| 895becc | 6.06 MiB | 7.03 MiB | 997.23 KiB |
| 7ade5af | 5.94 MiB | 6.95 MiB | 1.01 MiB |
| 0a23f98 | 6.06 MiB | 7.03 MiB | 996.97 KiB |
| 3a69405 | 5.94 MiB | 6.95 MiB | 1.01 MiB |
| ad69abc | 6.06 MiB | 7.09 MiB | 1.03 MiB |
| 9f9f94f | 5.94 MiB | 6.95 MiB | 1.01 MiB |
| deaeece | 5.94 MiB | 6.96 MiB | 1.02 MiB |
krystofwoldrich
left a comment
krystofwoldrich
left a comment
There was a problem hiding this comment.
Looks good. The PR is still a draft will you be adding something more?
I was just waiting CI/linting, but probably not. |
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #1435 +/- ##
=======================================
Coverage 90.20% 90.20%
=======================================
Files 181 181
Lines 5789 5789
=======================================
Hits 5222 5222
Misses 567 567
☔ View full report in Codecov by Sentry. |
iOS Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 6957bfd | 1283.80 ms | 1289.00 ms | 5.20 ms |
| c1bb00f | 1265.14 ms | 1290.85 ms | 25.71 ms |
| a49594a | 1284.83 ms | 1313.29 ms | 28.45 ms |
| 211a7aa | 1258.02 ms | 1275.65 ms | 17.63 ms |
| 457a85b | 1275.17 ms | 1285.51 ms | 10.34 ms |
| aed5947 | 1268.67 ms | 1281.10 ms | 12.43 ms |
| 8e133ad | 1268.19 ms | 1277.37 ms | 9.18 ms |
| 873fb42 | 1261.00 ms | 1285.92 ms | 24.92 ms |
| 90db9ff | 1277.18 ms | 1283.69 ms | 6.51 ms |
| 2f8f173 | 1280.61 ms | 1292.20 ms | 11.59 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 6957bfd | 8.15 MiB | 9.15 MiB | 1020.71 KiB |
| c1bb00f | 8.09 MiB | 9.07 MiB | 1001.06 KiB |
| a49594a | 8.16 MiB | 9.16 MiB | 1.00 MiB |
| 211a7aa | 8.10 MiB | 9.18 MiB | 1.08 MiB |
| 457a85b | 8.09 MiB | 9.07 MiB | 1000.88 KiB |
| aed5947 | 8.16 MiB | 9.17 MiB | 1.01 MiB |
| 8e133ad | 8.10 MiB | 9.16 MiB | 1.07 MiB |
| 873fb42 | 8.16 MiB | 9.17 MiB | 1.01 MiB |
| 90db9ff | 8.10 MiB | 9.08 MiB | 1004.27 KiB |
| 2f8f173 | 8.15 MiB | 9.13 MiB | 1000.39 KiB |
| level: level.toSentryLevel(), | ||
| message: SentryMessage(message), | ||
| throwable: error, | ||
| // ignore: deprecated_member_use |
There was a problem hiding this comment.
Hello, I would like to see PR that migrates the current variables in extra so that I can replicate the same steps on our app that has a custom implementation of sentry_logging
is is ok to attach specific error data to the suggested context?
There was a problem hiding this comment.
yes, it's preferred actually https://docs.sentry.io/platforms/python/enriching-events/context/#additional-data
Although extra still works, and its probably not going to be removed any time soon, it's a soft deprecation as of now.
4 participants
📜 Description
Deprecate
extrain favor ofcontexts.💡 Motivation and Context
https://docs.sentry.io/platforms/python/enriching-events/context/#additional-data
💚 How did you test it?
📝 Checklist
sendDefaultPiiis enabled🔮 Next steps