Skip to content

Add attachments to Hint#1404

Merged
marandaneto merged 14 commits into
mainfrom
feat/hint-attachments
Apr 25, 2023
Merged

Add attachments to Hint#1404
marandaneto merged 14 commits into
mainfrom
feat/hint-attachments

Conversation

@denrase

@denrase denrase commented Apr 25, 2023

Copy link
Copy Markdown
Collaborator

📜 Description

  • Add attachments to Hint

💡 Motivation and Context

Closes #682

💚 How did you test it?

  • Added tests

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPii is enabled
  • I updated the docs if needed
  • All tests passing
  • No breaking changes

@github-actions

github-actions Bot commented Apr 25, 2023

Copy link
Copy Markdown
Contributor
Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 7670e73

@codecov

codecov Bot commented Apr 25, 2023

Copy link
Copy Markdown

Codecov Report

Patch coverage has no change and project coverage change: -0.68 ⚠️

Comparison is base (9949058) 91.46% compared to head (a8e2293) 90.78%.

❗ Current head a8e2293 differs from pull request most recent head 7670e73. Consider uploading reports for the commit 7670e73 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1404      +/-   ##
==========================================
- Coverage   91.46%   90.78%   -0.68%     
==========================================
  Files         169       61     -108     
  Lines        5296     2041    -3255     
==========================================
- Hits         4844     1853    -2991     
+ Misses        452      188     -264     

see 132 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Comment thread CHANGELOG.md
Comment thread dart/lib/src/sentry_client.dart Outdated
Comment thread dart/lib/src/hint.dart Outdated
@denrase
denrase marked this pull request as ready for review April 25, 2023 08:07
@denrase
denrase requested a review from marandaneto April 25, 2023 08:07
Comment thread CHANGELOG.md
@marandaneto
marandaneto merged commit d85ffe7 into main Apr 25, 2023
@marandaneto
marandaneto deleted the feat/hint-attachments branch April 25, 2023 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

(PR created) Allow attachments to be bound to exception more easily

2 participants