Skip to content

Add processor count to device info#1402

Merged
marandaneto merged 4 commits into
mainfrom
chore/device-info-cpu-count
Apr 24, 2023
Merged

Add processor count to device info#1402
marandaneto merged 4 commits into
mainfrom
chore/device-info-cpu-count

Conversation

@marandaneto

@marandaneto marandaneto commented Apr 21, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

📜 Description

💡 Motivation and Context

getsentry/team-mobile#77
Fixes #1401

💚 How did you test it?

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPii is enabled
  • I updated the docs if needed
  • All tests passing
  • No breaking changes

🔮 Next steps

This was referenced Apr 21, 2023
Closed
Merged
@codecov

codecov Bot commented Apr 21, 2023 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Patch coverage has no change and project coverage change: +1.27 🎉

Comparison is base (fed8146) 88.64% compared to head (a29ac2a) 89.92%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1402      +/-   ##
==========================================
+ Coverage   88.64%   89.92%   +1.27%     
==========================================
  Files         139      179      +40     
  Lines        4376     5765    +1389     
==========================================
+ Hits         3879     5184    +1305     
- Misses        497      581      +84

see 40 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ueman

ueman commented Apr 21, 2023

Copy link
Copy Markdown
Collaborator

sentry-dart/dart/lib/src/event_processor/enricher/io_enricher_event_processor.dart

Line 104 in fed8146

processorCount: device?.processorCount ?? Platform.numberOfProcessors,

Does that need to be changed too?

@marandaneto

marandaneto commented Apr 21, 2023

Copy link
Copy Markdown
Contributor Author

sentry-dart/dart/lib/src/event_processor/enricher/io_enricher_event_processor.dart

Line 104 in fed8146

processorCount: device?.processorCount ?? Platform.numberOfProcessors,

Does that need to be changed too?

Nope because device?.processorCount is going to be populated, also because hasNativeIntegration is true so it won't fallback to _getDevice, its still gonna be useful for non native plats.

krystofwoldrich
krystofwoldrich reviewed Apr 24, 2023
View reviewed changes
Comment thread flutter/ios/Classes/SentryFlutterPluginApple.swift Outdated
krystofwoldrich
krystofwoldrich approved these changes Apr 24, 2023
View reviewed changes

@krystofwoldrich krystofwoldrich left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@marandaneto
marandaneto enabled auto-merge (squash) April 24, 2023 10:57
@marandaneto
marandaneto merged commit bc489d4 into main Apr 24, 2023
@marandaneto
marandaneto deleted the chore/device-info-cpu-count branch April 24, 2023 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brustolin brustolin Awaiting requested review from brustolin
1 more reviewer
@krystofwoldrich krystofwoldrich krystofwoldrich approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Use getExtraContext on iOS

3 participants

@marandaneto @ueman @krystofwoldrich