Skip to content

Do not report only async gap frames for logging calls#1398

Merged
marandaneto merged 5 commits into
mainfrom
fix/logging-async-gap
Apr 20, 2023
Merged

Do not report only async gap frames for logging calls#1398
marandaneto merged 5 commits into
mainfrom
fix/logging-async-gap

Conversation

@marandaneto

@marandaneto marandaneto commented Apr 19, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

📜 Description

Also upgraded the tooling to compile with Java 17
#1399 was merged into this PR.

💡 Motivation and Context

Fixes #1392

💚 How did you test it?

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPii is enabled
  • I updated the docs if needed
  • All tests passing
  • No breaking changes

🔮 Next steps

marandaneto
marandaneto commented Apr 19, 2023
View reviewed changes
Comment thread flutter/example/lib/main.dart Outdated
@codecov

codecov Bot commented Apr 19, 2023 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Patch coverage: 100.00% and project coverage change: -1.14 ⚠️

Comparison is base (b98109e) 91.04% compared to head (8035a72) 89.91%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1398      +/-   ##
==========================================
- Coverage   91.04%   89.91%   -1.14%     
==========================================
  Files         160      179      +19     
  Lines        5126     5759     +633     
==========================================
+ Hits         4667     5178     +511     
- Misses        459      581     +122
Impacted Files Coverage Δ
dart/lib/src/protocol/sentry_stack_frame.dart 100.00% <ø> (ø)
dart/lib/src/sentry_stack_trace_factory.dart 96.49% <100.00%> (+0.12%) ⬆️

... and 19 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions

github-actions Bot commented Apr 19, 2023

Copy link
Copy Markdown
Contributor

Android Performance metrics 🚀

  Plain With Sentry Diff
Startup time 309.39 ms 384.26 ms 74.87 ms
Size 6.06 MiB 7.03 MiB 994.94 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
6d7a391 331.94 ms 367.04 ms 35.10 ms
ad69abc 297.35 ms 385.89 ms 88.54 ms
559d28f 302.35 ms 339.53 ms 37.18 ms
4efee31 308.92 ms 368.68 ms 59.76 ms
e2d89fc 323.84 ms 376.23 ms 52.39 ms
8ced2dc 295.58 ms 336.49 ms 40.91 ms
e66e71e 296.84 ms 345.43 ms 48.59 ms
1c6eb5b 350.69 ms 393.86 ms 43.17 ms
9928a74 375.26 ms 456.30 ms 81.04 ms
464b4d0 320.71 ms 380.02 ms 59.31 ms

App size

Revision Plain With Sentry Diff
6d7a391 5.94 MiB 6.95 MiB 1.01 MiB
ad69abc 6.06 MiB 7.09 MiB 1.03 MiB
559d28f 5.94 MiB 6.92 MiB 1001.70 KiB
4efee31 5.94 MiB 6.92 MiB 1003.76 KiB
e2d89fc 6.06 MiB 7.03 MiB 989.37 KiB
8ced2dc 6.06 MiB 7.03 MiB 990.29 KiB
e66e71e 6.06 MiB 7.09 MiB 1.03 MiB
1c6eb5b 5.94 MiB 6.92 MiB 1001.53 KiB
9928a74 5.94 MiB 6.96 MiB 1.02 MiB
464b4d0 6.06 MiB 7.03 MiB 990.27 KiB

@github-actions

github-actions Bot commented Apr 19, 2023

Copy link
Copy Markdown
Contributor

iOS Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1285.67 ms 1304.17 ms 18.49 ms
Size 8.10 MiB 9.17 MiB 1.08 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
3637a22 1290.39 ms 1318.42 ms 28.03 ms
d7758e8 1271.69 ms 1288.08 ms 16.39 ms
5aba417 1265.31 ms 1287.90 ms 22.59 ms
22ed6cb 1277.41 ms 1283.76 ms 6.35 ms
ef2f368 1259.12 ms 1277.04 ms 17.92 ms
af2d175 1280.37 ms 1282.24 ms 1.88 ms
e5b744f 1250.82 ms 1284.46 ms 33.64 ms
6d7a391 1265.65 ms 1289.98 ms 24.33 ms
7f2b01d 1253.92 ms 1266.70 ms 12.78 ms
6325c3b 1266.52 ms 1291.06 ms 24.54 ms

App size

Revision Plain With Sentry Diff
3637a22 8.09 MiB 9.07 MiB 1001.02 KiB
d7758e8 8.15 MiB 9.12 MiB 989.76 KiB
5aba417 8.16 MiB 9.17 MiB 1.01 MiB
22ed6cb 8.10 MiB 9.17 MiB 1.08 MiB
ef2f368 8.15 MiB 9.10 MiB 965.24 KiB
af2d175 8.15 MiB 9.12 MiB 986.22 KiB
e5b744f 8.09 MiB 9.07 MiB 1001.19 KiB
6d7a391 8.16 MiB 9.16 MiB 1.01 MiB
7f2b01d 8.16 MiB 9.16 MiB 1.00 MiB
6325c3b 8.16 MiB 9.17 MiB 1.01 MiB

krystofwoldrich
krystofwoldrich reviewed Apr 20, 2023
View reviewed changes
Comment thread dart/test/stack_trace_test.dart
krystofwoldrich
krystofwoldrich approved these changes Apr 20, 2023
View reviewed changes

@krystofwoldrich krystofwoldrich left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Lot of things improved and fixed. Nice. 🚀

@marandaneto
marandaneto merged commit d69dd86 into main Apr 20, 2023
@marandaneto
marandaneto deleted the fix/logging-async-gap branch April 20, 2023 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brustolin brustolin Awaiting requested review from brustolin
1 more reviewer
@krystofwoldrich krystofwoldrich krystofwoldrich approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

All events captured by the logging integration are grouped together

2 participants

@marandaneto @krystofwoldrich