Skip to content

Fix: Breadcrumb data should accept serializable types and not only String values#139

Merged
marandaneto merged 3 commits into
feature/unified-apifrom
fix/breadcrumb-data
Oct 26, 2020
Merged

Fix: Breadcrumb data should accept serializable types and not only String values#139
marandaneto merged 3 commits into
feature/unified-apifrom
fix/breadcrumb-data

Conversation

@marandaneto

@marandaneto marandaneto commented Oct 26, 2020

Copy link
Copy Markdown
Contributor

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

Fix: Breadcrumb data should accept serializable types and not only String values

💡 Motivation and Context

https://develop.sentry.dev/sdk/event-payloads/breadcrumbs/
#129

💚 How did you test it?

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • All tests passing
  • No breaking changes

🔮 Next steps

@marandaneto marandaneto changed the title fix/breadcrumb data Fix: Breadcrumb data should accept serializable types and not only String values Oct 26, 2020
@marandaneto
marandaneto requested a review from rxlabz October 26, 2020 11:11
@marandaneto
marandaneto changed the base branch from main to feature/unified-api October 26, 2020 11:11
Comment thread CHANGELOG.md Outdated

@rxlabz rxlabz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Co-authored-by: Erick Ghaumez <[email protected]>
@marandaneto
marandaneto merged commit dc962ae into feature/unified-api Oct 26, 2020
@marandaneto
marandaneto deleted the fix/breadcrumb-data branch October 26, 2020 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants