Skip to content

Export SentryBaggage#1377

Merged
marandaneto merged 6 commits into
getsentry:mainfrom
ueman:patch-1
Apr 6, 2023
Merged

Export SentryBaggage#1377
marandaneto merged 6 commits into
getsentry:mainfrom
ueman:patch-1

Conversation

@ueman

@ueman ueman commented Apr 2, 2023

Copy link
Copy Markdown
Collaborator

📜 Description

This should be exported in order to use SentryBaggage.fromHeader() when starting traces from a header:

SentryTransactionContext.fromSentryTrace(
  description,
  'http.client',
  SentryTraceHeader.fromTraceHeader(traceHeaderValue),
  baggage: SentryBaggage.fromHeader(),
);

💡 Motivation and Context

See above

💚 How did you test it?

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPii is enabled
  • I updated the docs if needed
  • All tests passing
  • No breaking changes

🔮 Next steps

@codecov

codecov Bot commented Apr 2, 2023

Copy link
Copy Markdown

Codecov Report

Patch and project coverage have no change.

Comparison is base (498eced) 89.79% compared to head (e2098f2) 89.79%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1377   +/-   ##
=======================================
  Coverage   89.79%   89.79%           
=======================================
  Files          59       59           
  Lines        2018     2018           
=======================================
  Hits         1812     1812           
  Misses        206      206           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@marandaneto marandaneto left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ueman

@marandaneto
marandaneto enabled auto-merge (squash) April 6, 2023 07:46
@marandaneto
marandaneto merged commit ab7b7c9 into getsentry:main Apr 6, 2023
@ueman
ueman deleted the patch-1 branch April 6, 2023 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants