Skip to content

Move Isolate-related exports to sentry_io.dart#1371

Merged
marandaneto merged 5 commits into
getsentry:mainfrom
mnordine:web-fix
Mar 31, 2023
Merged

Move Isolate-related exports to sentry_io.dart#1371
marandaneto merged 5 commits into
getsentry:mainfrom
mnordine:web-fix

Conversation

@mnordine

Copy link
Copy Markdown
Contributor

Fixes #1369

@codecov

codecov Bot commented Mar 30, 2023

Copy link
Copy Markdown

Codecov Report

Patch and project coverage have no change.

Comparison is base (464b4d0) 89.90% compared to head (f68ed0a) 89.90%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1371   +/-   ##
=======================================
  Coverage   89.90%   89.90%           
=======================================
  Files         179      179           
  Lines        5755     5755           
=======================================
  Hits         5174     5174           
  Misses        581      581           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@marandaneto

Copy link
Copy Markdown
Contributor

@mnordine Can you address and provide more info as asked here?

I'm not against the change but there's a trade-off here and I can't reproduce your issue.
People would need to import sentry_io.dart instead of sentry.dart.

@marandaneto

Copy link
Copy Markdown
Contributor

@mnordine can you add a changelog entry?

@mnordine

Copy link
Copy Markdown
Contributor Author

@marandaneto Do you want me to update pubspec.yaml, too?

Comment thread CHANGELOG.md Outdated
@marandaneto

Copy link
Copy Markdown
Contributor

@marandaneto Do you want me to update pubspec.yaml, too?

The release process does it automatically.

@marandaneto
marandaneto enabled auto-merge (squash) March 31, 2023 14:25
Comment thread CHANGELOG.md Outdated

@marandaneto marandaneto left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mnordine

@marandaneto
marandaneto merged commit b9da046 into getsentry:main Mar 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Version 7 broke web builds

2 participants