Skip to content

Fix enableAutoNativeBreadcrumbs and enableNativeCrashHandling sync flags#1367

Merged
marandaneto merged 3 commits into
mainfrom
fix/sync-enable-flags
Mar 29, 2023
Merged

Fix enableAutoNativeBreadcrumbs and enableNativeCrashHandling sync flags#1367
marandaneto merged 3 commits into
mainfrom
fix/sync-enable-flags

Conversation

@marandaneto

@marandaneto marandaneto commented Mar 29, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

📜 Description

Flags were synced but not used.

💡 Motivation and Context

Regression from https://github.com/getsentry/sentry-dart/pull/1354/files

💚 How did you test it?

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPii is enabled
  • I updated the docs if needed
  • All tests passing
  • No breaking changes

🔮 Next steps

marandaneto
marandaneto commented Mar 29, 2023
View reviewed changes
Comment thread flutter/example/ios/Runner.xcodeproj/project.pbxproj
ASSETCATALOG_COMPILER_APPICON_NAME = AppIcon;
CLANG_ENABLE_MODULES = YES;
CURRENT_PROJECT_VERSION = "$(FLUTTER_BUILD_NUMBER)";
DEVELOPMENT_TEAM = 97JCY7859U;

@marandaneto marandaneto Mar 29, 2023

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using Sentry team.

@codecov

codecov Bot commented Mar 29, 2023 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Patch and project coverage have no change.

Comparison is base (a61674e) 89.90% compared to head (1045534) 89.90%.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1367   +/-   ##
=======================================
  Coverage   89.90%   89.90%           
=======================================
  Files         179      179           
  Lines        5755     5755           
=======================================
  Hits         5174     5174           
  Misses        581      581

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions

github-actions Bot commented Mar 29, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

Android Performance metrics 🚀

  Plain With Sentry Diff
Startup time 329.91 ms 377.04 ms 47.13 ms
Size 6.06 MiB 7.03 MiB 990.29 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
e893df5 310.60 ms 380.58 ms 69.98 ms
4efee31 308.92 ms 368.68 ms 59.76 ms
ecb4003 332.58 ms 385.15 ms 52.57 ms
cdf7172 348.54 ms 390.81 ms 42.27 ms
a2ec542 322.27 ms 372.87 ms 50.60 ms
7ade5af 341.04 ms 386.84 ms 45.80 ms
40680d3 323.55 ms 390.29 ms 66.73 ms
0db91cc 327.85 ms 387.31 ms 59.46 ms
a61674e 331.35 ms 391.06 ms 59.71 ms
b49bf00 323.46 ms 375.35 ms 51.89 ms

App size

Revision Plain With Sentry Diff
e893df5 6.06 MiB 7.09 MiB 1.03 MiB
4efee31 5.94 MiB 6.92 MiB 1003.76 KiB
ecb4003 6.06 MiB 7.09 MiB 1.03 MiB
cdf7172 5.94 MiB 6.95 MiB 1.01 MiB
a2ec542 6.06 MiB 7.10 MiB 1.04 MiB
7ade5af 5.94 MiB 6.95 MiB 1.01 MiB
40680d3 6.06 MiB 7.03 MiB 989.25 KiB
0db91cc 5.94 MiB 6.95 MiB 1.01 MiB
a61674e 6.06 MiB 7.03 MiB 990.29 KiB
b49bf00 6.06 MiB 7.10 MiB 1.04 MiB

Previous results on branch: fix/sync-enable-flags

Startup times

Revision Plain With Sentry Diff
7d4abc0 351.79 ms 374.98 ms 23.19 ms

App size

Revision Plain With Sentry Diff
7d4abc0 6.06 MiB 7.03 MiB 990.28 KiB

@github-actions

github-actions Bot commented Mar 29, 2023

Copy link
Copy Markdown
Contributor

iOS Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1267.33 ms 1286.10 ms 18.78 ms
Size 8.10 MiB 9.16 MiB 1.07 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
5aba417 1265.31 ms 1287.90 ms 22.59 ms
5603ab2 1268.47 ms 1280.73 ms 12.26 ms
eecbbca 1264.90 ms 1286.33 ms 21.43 ms
b728df4 1287.43 ms 1293.94 ms 6.51 ms
0ceb89c 1252.02 ms 1271.78 ms 19.75 ms
3e5ee37 1248.25 ms 1265.38 ms 17.13 ms
f1314d5 1246.46 ms 1270.92 ms 24.46 ms
ecb4003 1266.94 ms 1290.24 ms 23.31 ms
873fb42 1261.00 ms 1285.92 ms 24.92 ms
49a149b 1296.47 ms 1320.20 ms 23.73 ms

App size

Revision Plain With Sentry Diff
5aba417 8.16 MiB 9.17 MiB 1.01 MiB
5603ab2 8.15 MiB 9.12 MiB 990.57 KiB
eecbbca 8.15 MiB 9.10 MiB 965.26 KiB
b728df4 8.15 MiB 9.15 MiB 1020.72 KiB
0ceb89c 8.15 MiB 9.12 MiB 989.78 KiB
3e5ee37 8.15 MiB 9.12 MiB 986.23 KiB
f1314d5 8.10 MiB 9.08 MiB 1004.30 KiB
ecb4003 8.09 MiB 9.07 MiB 1000.82 KiB
873fb42 8.16 MiB 9.17 MiB 1.01 MiB
49a149b 8.15 MiB 9.12 MiB 986.26 KiB

krystofwoldrich
krystofwoldrich approved these changes Mar 29, 2023
View reviewed changes

@krystofwoldrich krystofwoldrich left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@marandaneto
marandaneto merged commit 9ee7b91 into main Mar 29, 2023
@marandaneto
marandaneto deleted the fix/sync-enable-flags branch March 29, 2023 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brustolin brustolin Awaiting requested review from brustolin
1 more reviewer
@krystofwoldrich krystofwoldrich krystofwoldrich approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@marandaneto @krystofwoldrich