Fix SentryUserInteractionWidget throwing when Sentry is not enabled#1363
Merged
Conversation
kuhnroyal
requested review from
brustolin,
krystofwoldrich and
marandaneto
as code owners
March 27, 2023 22:46
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1363 +/- ##
==========================================
- Coverage 91.02% 89.89% -1.14%
==========================================
Files 160 179 +19
Lines 5113 5747 +634
==========================================
+ Hits 4654 5166 +512
- Misses 459 581 +122
... and 19 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
marandaneto
approved these changes
Mar 28, 2023
marandaneto
left a comment
marandaneto
left a comment
Contributor
There was a problem hiding this comment.
good catch @kuhnroyal
can you add a changelog entry? thanks
Contributor
Author
Done |
marandaneto
enabled auto-merge (squash)
March 28, 2023 10:44
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
SentryUserInteractionWidgetalways attempts to cast thehub.optionstoSentryFlutterOptions- this cast can fail ifSentry.isEnabledis false or due do bad configuration. A simple type check was added to avoid this.💡 Motivation and Context
💚 How did you test it?
📝 Checklist
sendDefaultPiiis enabled🔮 Next steps
Not sure what more to test.