SentryUserInteractionWidget: add support for PopupMenuButton and PopupMenuItem#1361
Merged
Conversation
sstasi95
requested review from
brustolin,
krystofwoldrich and
marandaneto
as code owners
March 27, 2023 15:11
marandaneto
approved these changes
Mar 28, 2023
marandaneto
left a comment
marandaneto
left a comment
Contributor
There was a problem hiding this comment.
Thanks @sstasi95
Can you add a changelog entry?
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #1361 +/- ##
==========================================
- Coverage 89.75% 80.72% -9.03%
==========================================
Files 59 19 -40
Lines 2010 633 -1377
==========================================
- Hits 1804 511 -1293
+ Misses 206 122 -84 see 40 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
Contributor
Author
|
@marandaneto done |
marandaneto
enabled auto-merge (squash)
March 28, 2023 11:13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
This PR adds support for PopupMenuButton and PopupMenuItem in SentryUserInteractionWidget. In this way, interactions with popup menus are automatically tracked.
Fixes #1360
💡 Motivation and Context
Many widgets are already supported by SentryUserInteractionWidget, but PopupMenuButton and PopupMenuItem currently are not.
💚 How did you test it?
Running
flutter test📝 Checklist
sendDefaultPiiis enabled