Add missing props#1354
Merged
Merged
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1354 +/- ##
=======================================
Coverage 89.96% 89.96%
=======================================
Files 176 176
Lines 5563 5563
=======================================
Hits 5005 5005
Misses 558 558
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
Contributor
Android Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 68677de | 364.41 ms | 415.61 ms | 51.20 ms |
| c1bb00f | 303.77 ms | 371.88 ms | 68.11 ms |
| 5603ab2 | 309.84 ms | 345.20 ms | 35.36 ms |
| 633cf2e | 289.36 ms | 340.38 ms | 51.02 ms |
| 9c5aec6 | 287.33 ms | 320.94 ms | 33.61 ms |
| 333903e | 332.76 ms | 406.86 ms | 74.10 ms |
| 1edf30e | 334.00 ms | 378.35 ms | 44.35 ms |
| fe4aa56 | 356.06 ms | 428.67 ms | 72.61 ms |
| d301b11 | 337.96 ms | 395.04 ms | 57.08 ms |
| 6e083bb | 327.96 ms | 381.39 ms | 53.43 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 68677de | 6.06 MiB | 7.10 MiB | 1.04 MiB |
| c1bb00f | 6.06 MiB | 7.09 MiB | 1.03 MiB |
| 5603ab2 | 5.94 MiB | 6.95 MiB | 1.01 MiB |
| 633cf2e | 5.94 MiB | 6.92 MiB | 1001.53 KiB |
| 9c5aec6 | 5.94 MiB | 6.92 MiB | 1001.61 KiB |
| 333903e | 6.06 MiB | 7.10 MiB | 1.04 MiB |
| 1edf30e | 5.94 MiB | 6.96 MiB | 1.02 MiB |
| fe4aa56 | 6.06 MiB | 7.10 MiB | 1.04 MiB |
| d301b11 | 6.06 MiB | 7.09 MiB | 1.03 MiB |
| 6e083bb | 5.94 MiB | 6.97 MiB | 1.03 MiB |
Contributor
iOS Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| ecb4003 | 1266.94 ms | 1290.24 ms | 23.31 ms |
| 6957bfd | 1283.80 ms | 1289.00 ms | 5.20 ms |
| 5aab4c5 | 1247.08 ms | 1271.17 ms | 24.09 ms |
| f1314d5 | 1246.46 ms | 1270.92 ms | 24.46 ms |
| fe4aa56 | 1248.82 ms | 1261.35 ms | 12.53 ms |
| 6325c3b | 1266.52 ms | 1291.06 ms | 24.54 ms |
| ef2f368 | 1259.12 ms | 1277.04 ms | 17.92 ms |
| 379d7a8 | 1267.65 ms | 1288.39 ms | 20.74 ms |
| 08a7b4f | 1277.10 ms | 1303.37 ms | 26.27 ms |
| 7f2b01d | 1253.92 ms | 1266.70 ms | 12.78 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| ecb4003 | 8.09 MiB | 9.07 MiB | 1000.82 KiB |
| 6957bfd | 8.15 MiB | 9.15 MiB | 1020.71 KiB |
| 5aab4c5 | 8.10 MiB | 9.16 MiB | 1.07 MiB |
| f1314d5 | 8.10 MiB | 9.08 MiB | 1004.30 KiB |
| fe4aa56 | 8.10 MiB | 9.08 MiB | 1004.36 KiB |
| 6325c3b | 8.16 MiB | 9.17 MiB | 1.01 MiB |
| ef2f368 | 8.15 MiB | 9.10 MiB | 965.24 KiB |
| 379d7a8 | 8.16 MiB | 9.16 MiB | 1.00 MiB |
| 08a7b4f | 8.16 MiB | 9.16 MiB | 1.01 MiB |
| 7f2b01d | 8.16 MiB | 9.16 MiB | 1.00 MiB |
marandaneto
marked this pull request as ready for review
March 24, 2023 14:59
brustolin
approved these changes
Mar 27, 2023
marandaneto
commented
Mar 27, 2023
marandaneto
commented
Mar 27, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
💡 Motivation and Context
Some props were not synced down to native SDKs and features enabled by default could not be turned off.
💚 How did you test it?
📝 Checklist
sendDefaultPiiis enabled🔮 Next steps