Adapt DioErrorExtractor to new DioStackTraceExtractor usage#1344
Merged
marandaneto merged 4 commits intoMar 20, 2023
Merged
Conversation
kuhnroyal
requested review from
brustolin,
krystofwoldrich and
marandaneto
as code owners
March 17, 2023 16:38
marandaneto
approved these changes
Mar 18, 2023
marandaneto
enabled auto-merge (squash)
March 20, 2023 10:27
Contributor
|
Thanks @kuhnroyal |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1344 +/- ##
==========================================
- Coverage 89.67% 89.66% -0.01%
==========================================
Files 59 59
Lines 1995 1994 -1
==========================================
- Hits 1789 1788 -1
Misses 206 206
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
This change now respects the new
DioStackTraceExtractorand no longer extractsDioErrpr.stackTraceviaDioErrorExtractor💡 Motivation and Context
💚 How did you test it?
📝 Checklist
sendDefaultPiiis enabled🔮 Next steps
CC @ueman @marandaneto