Skip to content

Include and set ProGuard uuid in Flutter Options#1312

Merged
marandaneto merged 6 commits into
getsentry:mainfrom
Wcisang:feat/flutter-proguard-support
Mar 6, 2023
Merged

Include and set ProGuard uuid in Flutter Options#1312
marandaneto merged 6 commits into
getsentry:mainfrom
Wcisang:feat/flutter-proguard-support

Conversation

@Wcisang

@Wcisang Wcisang commented Mar 3, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

📜 Description

I just added a proGuardUuid property to the Options and passed it to Sentry's android native initialization.

💡 Motivation and Context

Due to the flutter SDK not having support to configure the proguard uuid, it is necessary to perform a large workaround to perform this action.
So this simple modification already makes it possible for Flutter apps to configure the proguard uuid at runtime.

💚 How did you test it?

created unit tests for testing defaults and custom values

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPii is enabled
  • I updated the docs if needed
  • All tests passing
  • No breaking changes

🔮 Next steps

marandaneto
marandaneto reviewed Mar 3, 2023
View reviewed changes
Comment thread dart/lib/src/sentry_options.dart Outdated
marandaneto
marandaneto reviewed Mar 3, 2023
View reviewed changes
Comment thread dart/lib/src/sentry_options.dart Outdated
@marandaneto

marandaneto commented Mar 3, 2023

Copy link
Copy Markdown
Contributor

@Wcisang you could technically set it directly into the Manifest file on Android.
Does that help?

@codecov

codecov Bot commented Mar 3, 2023 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.21 ⚠️

Comparison is base (b49bf00) 90.03% compared to head (efd7d46) 89.83%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1312      +/-   ##
==========================================
- Coverage   90.03%   89.83%   -0.21%     
==========================================
  Files         110      155      +45     
  Lines        3483     5064    +1581     
==========================================
+ Hits         3136     4549    +1413     
- Misses        347      515     +168
Impacted Files Coverage Δ
flutter/lib/src/sentry_flutter_options.dart 73.33% <ø> (ø)
...r/lib/src/integrations/native_sdk_integration.dart 100.00% <100.00%> (ø)
...lib/src/integrations/load_release_integration.dart 100.00% <0.00%> (ø)
.../lib/src/navigation/sentry_navigator_observer.dart 98.94% <0.00%> (ø)
...rc/screenshot/screenshot_attachment_processor.dart 76.00% <0.00%> (ø)
dio/lib/src/dio_event_processor.dart 96.36% <0.00%> (ø)
flutter/lib/src/jvm/jvm_exception.dart 100.00% <0.00%> (ø)
.../src/integrations/load_image_list_integration.dart 96.00% <0.00%> (ø)
...egrations/widgets_flutter_binding_integration.dart 100.00% <0.00%> (ø)
...t_processor/flutter_exception_event_processor.dart 100.00% <0.00%> (ø)
... and 37 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Wcisang

Wcisang commented Mar 3, 2023

Copy link
Copy Markdown
Contributor Author

@marandaneto
Because we use a protection tool that runs after the build in the pipeline and the obfuscation map changes completely every run. And with that, we need to set this configuration at runtime.

marandaneto
marandaneto approved these changes Mar 6, 2023
View reviewed changes

@marandaneto marandaneto left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Wcisang
Before merging, please add an entry to our changelog :)

@Wcisang

Wcisang commented Mar 6, 2023

Copy link
Copy Markdown
Contributor Author

Thanks @Wcisang Before merging, please add an entry to our changelog :)

Done!
When does the next release happen?

@marandaneto
marandaneto enabled auto-merge (squash) March 6, 2023 15:06
@marandaneto

marandaneto commented Mar 6, 2023

Copy link
Copy Markdown
Contributor

Thanks @Wcisang Before merging, please add an entry to our changelog :)

Done! When does the next release happen?

I can cut a release once CI is happy, just fixed a detekt issue.

@marandaneto
marandaneto merged commit 90db9ff into getsentry:main Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brustolin brustolin Awaiting requested review from brustolin
@krystofwoldrich krystofwoldrich Awaiting requested review from krystofwoldrich
1 more reviewer
@marandaneto marandaneto marandaneto approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Wcisang @marandaneto