Chore: Only await futures#1310
Merged
Merged
Conversation
ueman
requested review from
brustolin,
krystofwoldrich and
marandaneto
as code owners
March 2, 2023 19:59
ueman
commented
Mar 2, 2023
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## v7.0.0 #1310 +/- ##
==========================================
+ Coverage 90.27% 90.30% +0.02%
==========================================
Files 164 164
Lines 5174 5189 +15
==========================================
+ Hits 4671 4686 +15
Misses 503 503
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
marandaneto
reviewed
Mar 3, 2023
Co-authored-by: Manoel Aranda Neto <[email protected]>
Contributor
I guess you covered most of them, maybe missing are |
marandaneto
reviewed
Mar 6, 2023
| } | ||
|
|
||
| Future<Scope> _cloneAndRunWithScope( | ||
| FutureOr<Scope> _cloneAndRunWithScope( |
marandaneto
reviewed
Mar 6, 2023
| _CachedItem(this._dataFactory); | ||
|
|
||
| final Future<List<int>> Function() _dataFactory; | ||
| final FutureOr<List<int>> Function() _dataFactory; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
Fixes #870
By awaiting only futures, the performance can be marginally improved.
I did my best to find all instances, but I'm not sure I got all.
💡 Motivation and Context
My motivation is the strive for a better performance.
💚 How did you test it?
There are no changes in functionality, just in the implementation. So the existing tests cover these changes.
📝 Checklist
sendDefaultPiiis enabled🔮 Next steps