Skip to content

Fix Web Example build due to min. Dart version#1299

Merged
marandaneto merged 5 commits into
mainfrom
fix/web-example-build
Feb 28, 2023
Merged

Fix Web Example build due to min. Dart version#1299
marandaneto merged 5 commits into
mainfrom
fix/web-example-build

Conversation

@marandaneto

@marandaneto marandaneto commented Feb 28, 2023

Copy link
Copy Markdown
Contributor

📜 Description

Fix Web Example build due to min. Dart version
#skip-changelog

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPii is enabled
  • I updated the docs if needed
  • All tests passing
  • No breaking changes

🔮 Next steps

@marandaneto marandaneto mentioned this pull request Feb 28, 2023
Merged
6 tasks
@marandaneto marandaneto changed the title fix test Fix Web Example build due to min. Dart version Feb 28, 2023
krystofwoldrich
krystofwoldrich approved these changes Feb 28, 2023
View reviewed changes

@krystofwoldrich krystofwoldrich left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@codecov

codecov Bot commented Feb 28, 2023 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Patch coverage has no change and project coverage change: +0.71 🎉

Comparison is base (69670c9) 90.03% compared to head (091cee0) 90.75%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1299      +/-   ##
==========================================
+ Coverage   90.03%   90.75%   +0.71%     
==========================================
  Files         110      144      +34     
  Lines        3483     4736    +1253     
==========================================
+ Hits         3136     4298    +1162     
- Misses        347      438      +91
Impacted Files Coverage Δ
flutter/lib/src/sentry_asset_bundle.dart 94.91% <0.00%> (ø)
...t_processor/flutter_exception_event_processor.dart 100.00% <0.00%> (ø)
...src/integrations/native_app_start_integration.dart 77.77% <0.00%> (ø)
flutter/lib/src/sentry_native_channel.dart 80.35% <0.00%> (ø)
...r/lib/src/integrations/native_sdk_integration.dart 100.00% <0.00%> (ø)
...ib/src/integrations/flutter_error_integration.dart 100.00% <0.00%> (ø)
flutter/lib/src/renderer/renderer.dart 62.50% <0.00%> (ø)
flutter/lib/src/file_system_transport.dart 100.00% <0.00%> (ø)
...ter/lib/src/integrations/on_error_integration.dart 93.93% <0.00%> (ø)
.../src/integrations/load_image_list_integration.dart 96.00% <0.00%> (ø)
... and 24 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions

github-actions Bot commented Feb 28, 2023

Copy link
Copy Markdown
Contributor

Android Performance metrics 🚀

  Plain With Sentry Diff
Startup time 335.92 ms 395.78 ms 59.86 ms
Size 6.06 MiB 7.09 MiB 1.03 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
8fa3934 340.64 ms 407.92 ms 67.28 ms
fbf42af 323.04 ms 365.09 ms 42.04 ms
21d4150 379.31 ms 449.23 ms 69.93 ms
08a7b4f 346.47 ms 403.29 ms 56.82 ms
9811573 309.76 ms 402.60 ms 92.84 ms
c70e01a 331.04 ms 401.46 ms 70.42 ms
48e79fd 354.22 ms 391.46 ms 37.24 ms
3637a22 322.59 ms 390.00 ms 67.41 ms
4efee31 308.92 ms 368.68 ms 59.76 ms
6d7a391 331.94 ms 367.04 ms 35.10 ms

App size

Revision Plain With Sentry Diff
8fa3934 6.06 MiB 7.09 MiB 1.03 MiB
fbf42af 5.94 MiB 6.96 MiB 1.02 MiB
21d4150 5.94 MiB 6.97 MiB 1.03 MiB
08a7b4f 5.94 MiB 6.95 MiB 1.01 MiB
9811573 5.94 MiB 6.96 MiB 1.02 MiB
c70e01a 5.94 MiB 6.97 MiB 1.03 MiB
48e79fd 5.94 MiB 6.95 MiB 1.01 MiB
3637a22 6.06 MiB 7.09 MiB 1.03 MiB
4efee31 5.94 MiB 6.92 MiB 1003.76 KiB
6d7a391 5.94 MiB 6.95 MiB 1.01 MiB

@github-actions

github-actions Bot commented Feb 28, 2023

Copy link
Copy Markdown
Contributor

iOS Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1265.24 ms 1283.00 ms 17.76 ms
Size 8.10 MiB 9.08 MiB 1004.36 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
6e083bb 1244.33 ms 1264.60 ms 20.26 ms
deaeece 1252.82 ms 1279.04 ms 26.22 ms
c70e01a 1273.00 ms 1299.12 ms 26.12 ms
2d3b03d 1258.19 ms 1272.69 ms 14.50 ms
1edf30e 1254.43 ms 1272.82 ms 18.39 ms
7f2b01d 1253.92 ms 1266.70 ms 12.78 ms
3a69405 1292.84 ms 1303.96 ms 11.12 ms
ef2f368 1259.12 ms 1277.04 ms 17.92 ms
e5b744f 1250.82 ms 1284.46 ms 33.64 ms
5112c69 1272.76 ms 1293.37 ms 20.61 ms

App size

Revision Plain With Sentry Diff
6e083bb 8.16 MiB 9.17 MiB 1.01 MiB
deaeece 8.16 MiB 9.17 MiB 1.01 MiB
c70e01a 8.16 MiB 9.17 MiB 1.01 MiB
2d3b03d 8.10 MiB 9.07 MiB 1000.83 KiB
1edf30e 8.16 MiB 9.17 MiB 1.01 MiB
7f2b01d 8.16 MiB 9.16 MiB 1.00 MiB
3a69405 8.15 MiB 9.15 MiB 1018.56 KiB
ef2f368 8.15 MiB 9.10 MiB 965.24 KiB
e5b744f 8.09 MiB 9.07 MiB 1001.19 KiB
5112c69 8.16 MiB 9.17 MiB 1.01 MiB

@marandaneto
marandaneto merged commit 9cf0e40 into main Feb 28, 2023
@marandaneto
marandaneto deleted the fix/web-example-build branch February 28, 2023 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers
@brustolin brustolin brustolin approved these changes
@krystofwoldrich krystofwoldrich krystofwoldrich approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@marandaneto @brustolin @krystofwoldrich