Pass processed Breadcrumb to scope observer#1298
Merged
Merged
Conversation
denrase
marked this pull request as ready for review
February 28, 2023 14:51
denrase
requested review from
brustolin,
krystofwoldrich and
marandaneto
as code owners
February 28, 2023 14:51
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1298 +/- ##
==========================================
+ Coverage 89.36% 89.82% +0.46%
==========================================
Files 45 155 +110
Lines 1580 5063 +3483
==========================================
+ Hits 1412 4548 +3136
- Misses 168 515 +347
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Contributor
Android Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 8fa3934 | 340.64 ms | 407.92 ms | 67.28 ms |
| fbf42af | 323.04 ms | 365.09 ms | 42.04 ms |
| 21d4150 | 379.31 ms | 449.23 ms | 69.93 ms |
| 08a7b4f | 346.47 ms | 403.29 ms | 56.82 ms |
| 9811573 | 309.76 ms | 402.60 ms | 92.84 ms |
| c70e01a | 331.04 ms | 401.46 ms | 70.42 ms |
| 48e79fd | 354.22 ms | 391.46 ms | 37.24 ms |
| 3637a22 | 322.59 ms | 390.00 ms | 67.41 ms |
| 4efee31 | 308.92 ms | 368.68 ms | 59.76 ms |
| 6d7a391 | 331.94 ms | 367.04 ms | 35.10 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 8fa3934 | 6.06 MiB | 7.09 MiB | 1.03 MiB |
| fbf42af | 5.94 MiB | 6.96 MiB | 1.02 MiB |
| 21d4150 | 5.94 MiB | 6.97 MiB | 1.03 MiB |
| 08a7b4f | 5.94 MiB | 6.95 MiB | 1.01 MiB |
| 9811573 | 5.94 MiB | 6.96 MiB | 1.02 MiB |
| c70e01a | 5.94 MiB | 6.97 MiB | 1.03 MiB |
| 48e79fd | 5.94 MiB | 6.95 MiB | 1.01 MiB |
| 3637a22 | 6.06 MiB | 7.09 MiB | 1.03 MiB |
| 4efee31 | 5.94 MiB | 6.92 MiB | 1003.76 KiB |
| 6d7a391 | 5.94 MiB | 6.95 MiB | 1.01 MiB |
Contributor
iOS Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 21845e2 | 1279.37 ms | 1298.81 ms | 19.45 ms |
| b47809a | 1252.61 ms | 1278.57 ms | 25.96 ms |
| 49a149b | 1296.47 ms | 1320.20 ms | 23.73 ms |
| 5603ab2 | 1268.47 ms | 1280.73 ms | 12.26 ms |
| b728df4 | 1287.43 ms | 1293.94 ms | 6.51 ms |
| 21d4150 | 1252.86 ms | 1280.55 ms | 27.69 ms |
| 1edf30e | 1254.43 ms | 1272.82 ms | 18.39 ms |
| ccc09e4 | 1254.74 ms | 1277.08 ms | 22.34 ms |
| a49594a | 1284.83 ms | 1313.29 ms | 28.45 ms |
| c70e01a | 1273.00 ms | 1299.12 ms | 26.12 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 21845e2 | 8.15 MiB | 9.12 MiB | 991.34 KiB |
| b47809a | 8.16 MiB | 9.17 MiB | 1.01 MiB |
| 49a149b | 8.15 MiB | 9.12 MiB | 986.26 KiB |
| 5603ab2 | 8.15 MiB | 9.12 MiB | 990.57 KiB |
| b728df4 | 8.15 MiB | 9.15 MiB | 1020.72 KiB |
| 21d4150 | 8.16 MiB | 9.17 MiB | 1.01 MiB |
| 1edf30e | 8.16 MiB | 9.17 MiB | 1.01 MiB |
| ccc09e4 | 8.16 MiB | 9.16 MiB | 1.01 MiB |
| a49594a | 8.16 MiB | 9.16 MiB | 1.00 MiB |
| c70e01a | 8.16 MiB | 9.17 MiB | 1.01 MiB |
marandaneto
approved these changes
Feb 28, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
💡 Motivation and Context
Closes #1296
💚 How did you test it?
Unit tests
📝 Checklist
sendDefaultPiiis enabled🔮 Next steps