Allow sentry user to control resolution of captured Flutter screenshots#1288
Merged
Conversation
Contributor
|
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## v7.0.0 #1288 +/- ##
==========================================
+ Coverage 88.73% 90.30% +1.56%
==========================================
Files 122 165 +43
Lines 3818 5186 +1368
==========================================
+ Hits 3388 4683 +1295
- Misses 430 503 +73
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
denrase
marked this pull request as ready for review
February 20, 2023 16:24
denrase
requested review from
brustolin,
krystofwoldrich and
marandaneto
as code owners
February 20, 2023 16:24
marandaneto
reviewed
Mar 1, 2023
marandaneto
reviewed
Mar 1, 2023
Contributor
|
@denrase can we add testing for the screen quality? |
Collaborator
Author
|
@marandaneto Will check if we can add an integration test. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
SentryscreenshotQulityFull Quality:
Small Quality:
💡 Motivation and Context
Closes #1200
💚 How did you test it?
Ran different resolutions with sample app.
📝 Checklist
sendDefaultPiiis enabled