Set client name with version in sentry-android#1274
Merged
Conversation
Codecov ReportBase: 90.21% // Head: 90.21% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## v7.0.0 #1274 +/- ##
=======================================
Coverage 90.21% 90.21%
=======================================
Files 164 164
Lines 5143 5143
=======================================
Hits 4640 4640
Misses 503 503 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
marandaneto
reviewed
Feb 8, 2023
…rPlugin.kt Co-authored-by: Manoel Aranda Neto <[email protected]>
…h-version-android
…roid' into set-client-name-with-version-android
marandaneto
approved these changes
Feb 8, 2023
marandaneto
left a comment
marandaneto
left a comment
Contributor
There was a problem hiding this comment.
Thank you @krystofwoldrich
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
sentry_clientshould include the versionhttps://develop.sentry.dev/sdk/overview/#authentication
💡 Motivation and Context
sentryClientNameon Native SDKs during SDK init. team-mobile#48💚 How did you test it?
📝 Checklist
sendDefaultPiiis enabled🔮 Next steps