Skip to content

Fix isWeb check for WASM#1249

Merged
marandaneto merged 2 commits into
v7.0.0from
fix/isweb-wasm
Jan 26, 2023
Merged

Fix isWeb check for WASM#1249
marandaneto merged 2 commits into
v7.0.0from
fix/isweb-wasm

Conversation

@marandaneto

@marandaneto marandaneto commented Jan 26, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

📜 Description

Fix isWeb check for WASM

💡 Motivation and Context

Closes #1027
Relates to https://github.com/flutter/flutter/pull/112122/files

💚 How did you test it?

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPii is enabled
  • I updated the docs if needed
  • All tests passing
  • No breaking changes

🔮 Next steps

@codecov

codecov Bot commented Jan 26, 2023 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Base: 91.02% // Head: 90.06% // Decreases project coverage by -0.97% ⚠️

Coverage data is based on head (d76985b) compared to base (b5f0119).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files 
@@            Coverage Diff             @@
##           v7.0.0    #1249      +/-   ##
==========================================
- Coverage   91.02%   90.06%   -0.97%     
==========================================
  Files         162      164       +2     
  Lines        4982     5122     +140     
==========================================
+ Hits         4535     4613      +78     
- Misses        447      509      +62
Impacted Files Coverage Δ
dart/lib/src/platform_checker.dart 100.00% <100.00%> (ø)
file/lib/src/sentry_file.dart 54.13% <0.00%> (ø)
file/lib/src/sentry_file_extension.dart 80.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@marandaneto
marandaneto merged commit ce3cd20 into v7.0.0 Jan 26, 2023
@marandaneto
marandaneto deleted the fix/isweb-wasm branch January 26, 2023 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@krystofwoldrich krystofwoldrich Awaiting requested review from krystofwoldrich
1 more reviewer
@brustolin brustolin brustolin approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@marandaneto @brustolin