Skip to content

intl is now more version permissive#1247

Merged
marandaneto merged 3 commits into
mainfrom
fix/intl
Jan 25, 2023
Merged

intl is now more version permissive#1247
marandaneto merged 3 commits into
mainfrom
fix/intl

Conversation

@marandaneto

@marandaneto marandaneto commented Jan 25, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

📜 Description

pub has an addendun to sem ver and 0.x versions can be not compatible, using the > and < for now solves the problem, but we'd work on #1241 next.

💡 Motivation and Context

#1202 and dart-lang/pub#3747

💚 How did you test it?

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPii is enabled
  • I updated the docs if needed
  • All tests passing
  • No breaking changes

🔮 Next steps

#1241

@marandaneto marandaneto mentioned this pull request Jan 25, 2023
Closed
5 tasks
@codecov

codecov Bot commented Jan 25, 2023 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Base: 89.03% // Head: 89.72% // Increases project coverage by +0.69% 🎉

Coverage data is based on head (0ebed83) compared to base (053d819).
Patch has no changes to coverable lines.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1247      +/-   ##
==========================================
+ Coverage   89.03%   89.72%   +0.69%     
==========================================
  Files          45      155     +110     
  Lines        1550     5033    +3483     
==========================================
+ Hits         1380     4516    +3136     
- Misses        170      517     +347
Impacted Files Coverage Δ
dart/lib/src/sentry_client.dart 93.70% <0.00%> (ø)
...art/lib/src/http_client/failed_request_client.dart 93.61% <0.00%> (ø)
dart/lib/src/sentry_transaction_context.dart 95.23% <0.00%> (ø)
dart/lib/src/client_reports/discarded_event.dart 100.00% <0.00%> (ø)
dart/lib/src/protocol/sentry_event.dart 100.00% <0.00%> (ø)
dart/lib/src/protocol/sentry_level.dart 50.00% <0.00%> (ø)
dart/lib/src/protocol/sentry_stack_trace.dart 100.00% <0.00%> (ø)
...b/src/protocol/sentry_transaction_name_source.dart 85.71% <0.00%> (ø)
dart/lib/src/platform/platform.dart 57.14% <0.00%> (ø)
dart/lib/src/protocol/sentry_response.dart 82.75% <0.00%> (ø)
... and 100 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@marandaneto
marandaneto enabled auto-merge (squash) January 25, 2023 13:09
@github-actions

github-actions Bot commented Jan 25, 2023

Copy link
Copy Markdown
Contributor

Android Performance metrics 🚀

  Plain With Sentry Diff
Startup time 320.50 ms 364.77 ms 44.27 ms
Size 5.94 MiB 6.97 MiB 1.03 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
a1a1545 295.21 ms 351.16 ms 55.95 ms
08a7b4f 346.47 ms 403.29 ms 56.82 ms
25e9b59 307.00 ms 348.83 ms 41.83 ms
3f23617 385.77 ms 476.10 ms 90.33 ms
21d4150 379.31 ms 449.23 ms 69.93 ms
d7758e8 300.12 ms 349.88 ms 49.76 ms
5603ab2 309.84 ms 345.20 ms 35.36 ms
f922f8f 332.31 ms 374.67 ms 42.37 ms
1131914 317.90 ms 361.58 ms 43.69 ms
9811573 309.76 ms 402.60 ms 92.84 ms

App size

Revision Plain With Sentry Diff
a1a1545 5.94 MiB 6.96 MiB 1.02 MiB
08a7b4f 5.94 MiB 6.95 MiB 1.01 MiB
25e9b59 5.94 MiB 6.95 MiB 1.01 MiB
3f23617 5.94 MiB 6.96 MiB 1.02 MiB
21d4150 5.94 MiB 6.97 MiB 1.03 MiB
d7758e8 5.94 MiB 6.95 MiB 1.01 MiB
5603ab2 5.94 MiB 6.95 MiB 1.01 MiB
f922f8f 5.94 MiB 6.95 MiB 1.01 MiB
1131914 5.94 MiB 6.96 MiB 1.02 MiB
9811573 5.94 MiB 6.96 MiB 1.02 MiB

adinauer
adinauer approved these changes Jan 25, 2023
View reviewed changes

@adinauer adinauer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions

github-actions Bot commented Jan 25, 2023

Copy link
Copy Markdown
Contributor

iOS Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1235.48 ms 1263.59 ms 28.11 ms
Size 8.16 MiB 9.17 MiB 1.01 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
deaeece 1252.82 ms 1279.04 ms 26.22 ms
613760b 1263.10 ms 1277.27 ms 14.16 ms
a609134 1254.50 ms 1265.08 ms 10.58 ms
a510d1d 1277.04 ms 1291.57 ms 14.53 ms
8d64376 1260.92 ms 1289.32 ms 28.40 ms
9928a74 1249.98 ms 1269.08 ms 19.10 ms
3a69405 1292.84 ms 1303.96 ms 11.12 ms
af2d175 1280.37 ms 1282.24 ms 1.88 ms
691aa3b 1265.57 ms 1282.13 ms 16.55 ms
ef2f368 1259.12 ms 1277.04 ms 17.92 ms

App size

Revision Plain With Sentry Diff
deaeece 8.16 MiB 9.17 MiB 1.01 MiB
613760b 8.15 MiB 9.13 MiB 1000.46 KiB
a609134 8.16 MiB 9.16 MiB 1.01 MiB
a510d1d 8.16 MiB 9.17 MiB 1.01 MiB
8d64376 8.16 MiB 9.17 MiB 1.01 MiB
9928a74 8.16 MiB 9.17 MiB 1.01 MiB
3a69405 8.15 MiB 9.15 MiB 1018.56 KiB
af2d175 8.15 MiB 9.12 MiB 986.22 KiB
691aa3b 8.16 MiB 9.17 MiB 1.01 MiB
ef2f368 8.15 MiB 9.10 MiB 965.24 KiB

@marandaneto
marandaneto merged commit 50585f6 into main Jan 25, 2023
@marandaneto
marandaneto deleted the fix/intl branch January 25, 2023 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adinauer adinauer adinauer approved these changes
@brustolin brustolin Awaiting requested review from brustolin
@krystofwoldrich krystofwoldrich Awaiting requested review from krystofwoldrich

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@marandaneto @adinauer