Skip to content

Ref: Error Cause Extractor Updates#1236

Merged
marandaneto merged 7 commits into
v7.0.0from
ref/error-extractor-updates
Jan 24, 2023
Merged

Ref: Error Cause Extractor Updates#1236
marandaneto merged 7 commits into
v7.0.0from
ref/error-extractor-updates

Conversation

@denrase

@denrase denrase commented Jan 24, 2023

Copy link
Copy Markdown
Collaborator

📜 Description

Adds remaining feedback from #1198

@marandaneto After documenting the classes, I'm not sure abaut the Cause in the naming. Technically an inner exception does not have to be the cause of an exception i guess. So maybe we should replace Cause with Inner? WDYT?

💚 How did you test it?

Tests

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • I updated the docs if needed
  • All tests passing
  • No breaking changes

@codecov

codecov Bot commented Jan 24, 2023 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Base: 90.11% // Head: 90.21% // Increases project coverage by +0.10% 🎉

Coverage data is based on head (53f1356) compared to base (3bbfb14).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files 
@@            Coverage Diff             @@
##           v7.0.0    #1236      +/-   ##
==========================================
+ Coverage   90.11%   90.21%   +0.10%     
==========================================
  Files         113      124      +11     
  Lines        3510     3691     +181     
==========================================
+ Hits         3163     3330     +167     
- Misses        347      361      +14
Impacted Files Coverage Δ
dart/lib/src/exception_cause.dart 100.00% <ø> (ø)
dart/lib/src/exception_cause_extractor.dart 100.00% <ø> (ø)
dart/lib/src/sentry_exception_factory.dart 100.00% <ø> (ø)
dart/lib/src/sentry_options.dart 82.92% <ø> (ø)
...t/lib/src/recursive_exception_cause_extractor.dart 100.00% <100.00%> (ø)
dio/lib/src/sentry_dio_extension.dart 93.33% <100.00%> (ø)
logging/lib/src/logging_integration.dart 91.66% <0.00%> (ø)
dio/lib/src/tracing_client_adapter.dart 85.71% <0.00%> (ø)
dio/lib/src/breadcrumb_client_adapter.dart 80.00% <0.00%> (ø)
... and 6 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@denrase
denrase marked this pull request as ready for review January 24, 2023 09:54
ueman
ueman reviewed Jan 24, 2023
View reviewed changes
Comment thread dart/lib/src/exception_cause_extractor.dart Outdated
marandaneto
marandaneto reviewed Jan 24, 2023
View reviewed changes
Comment thread dart/lib/src/recursive_exception_cause_extractor.dart
marandaneto
marandaneto reviewed Jan 24, 2023
View reviewed changes
Comment thread dart/lib/src/recursive_exception_cause_extractor.dart
marandaneto
marandaneto reviewed Jan 24, 2023
View reviewed changes
Comment thread CHANGELOG.md Outdated
@marandaneto

marandaneto commented Jan 24, 2023

Copy link
Copy Markdown
Contributor

@denrase

@marandaneto After documenting the classes, I'm not sure abaut the Cause in the naming. Technically an inner exception does not have to be the cause of an exception i guess. So maybe we should replace Cause with Inner? WDYT?

Yeah that's true but usually, it is the cause.
Java calls cause as well, I dont have a strong opinion tbh, I am fine either way.

@denrase
denrase requested review from marandaneto and ueman January 24, 2023 13:25
@marandaneto
marandaneto merged commit 4c03039 into v7.0.0 Jan 24, 2023
@marandaneto
marandaneto deleted the ref/error-extractor-updates branch January 24, 2023 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brustolin brustolin Awaiting requested review from brustolin
@krystofwoldrich krystofwoldrich Awaiting requested review from krystofwoldrich
@ueman ueman Awaiting requested review from ueman
1 more reviewer
@marandaneto marandaneto marandaneto approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@denrase @marandaneto @ueman