Rename APM tracking feature flags to tracing and enable features by default#1222
Merged
Merged
Conversation
marandaneto
changed the title
marandaneto
marked this pull request as ready for review
January 12, 2023 13:02
marandaneto
requested review from
brustolin and
krystofwoldrich
as code owners
January 12, 2023 13:02
This was referenced Jan 12, 2023
Closed
Codecov ReportBase: 89.76% // Head: 88.64% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## chore/migrate-to-sentry-cocoa-v8 #1222 +/- ##
====================================================================
- Coverage 89.76% 88.64% -1.13%
====================================================================
Files 111 122 +11
Lines 3489 3822 +333
====================================================================
+ Hits 3132 3388 +256
- Misses 357 434 +77
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
marandaneto
commented
Jan 16, 2023
5 tasks
denrase
approved these changes
Jan 16, 2023
denrase
left a comment
denrase
left a comment
Collaborator
There was a problem hiding this comment.
One comment, other than that LGTM. Also updated the other PR now to build.
…ions # Conflicts: # flutter/ios/Classes/SentryFlutterPluginApple.swift # flutter/ios/sentry_flutter.podspec
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
Rename APM tracking feature flags to tracing and enable features by default
💡 Motivation and Context
Closes #1177
💚 How did you test it?
📝 Checklist
🔮 Next steps