Enable APM features by default#1217
Merged
Merged
Conversation
marandaneto
requested review from
brustolin and
krystofwoldrich
as code owners
January 10, 2023 12:44
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| - Use `sentryClientName` instead of `sdk.identifier` ([#1135](https://github.com/getsentry/sentry-dart/pull/1135)) | ||
| - Refactor `BindingUtils` to `BindingWrapper` to enable the use of custom bindings ([#1184](https://github.com/getsentry/sentry-dart/pull/1184)) | ||
| - Bump Flutter min to 3.0.0 and Dart to 2.17.0 ([#1180](https://github.com/getsentry/sentry-dart/pull/1180)) | ||
| - Enable APM features by default ([#1217](https://github.com/getsentry/sentry-dart/pull/1217)) |
Contributor
There was a problem hiding this comment.
- 🚫 The changelog entry seems to be part of an already released section
## 7.0.0.
Consider moving the entry to the## Unreleasedsection, please.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## v7.0.0 #1217 +/- ##
=========================================
Coverage ? 88.02%
=========================================
Files ? 120
Lines ? 3784
Branches ? 0
=========================================
Hits ? 3331
Misses ? 453
Partials ? 0 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
ueman
reviewed
Jan 10, 2023
brustolin
approved these changes
Jan 10, 2023
brustolin
left a comment
brustolin
left a comment
Contributor
There was a problem hiding this comment.
Looks like CHANGELOG is wrong, but other than that LGTM.
Contributor
Author
Good catch, fixed. |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
💡 Motivation and Context
Closes #1173
💚 How did you test it?
📝 Checklist
🔮 Next steps