Chore: Migrate to sentry cocoa v8 by denrase · Pull Request #1197 · getsentry/sentry-dart

denrase · 2022-12-19T14:19:58Z

📜 Description

Closes #1161
Closes #1185

💚 How did you test it?

Updated tests

📝 Checklist

…nableAutoPerformanceTracing

codecov-commenter · 2022-12-19T14:26:54Z

Codecov Report

❗ No coverage uploaded for pull request base (v7.0.0@fab2a9a). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files

@@            Coverage Diff            @@
##             v7.0.0    #1197   +/-   ##
=========================================
  Coverage          ?   89.90%           
=========================================
  Files             ?      120           
  Lines             ?     3684           
  Branches          ?        0           
=========================================
  Hits              ?     3312           
  Misses            ?      372           
  Partials          ?        0

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

…ope in this pr

# Conflicts: # flutter/ios/sentry_flutter.podspec

marandaneto · 2023-01-10T08:13:31Z

@denrase I have changed to 8.0.0-rc.1
Not sure if there are more breaking changes, can you take a look?

@brustolin and @philipphofmann would you be kind to review this as well? thanks.

marandaneto · 2023-01-10T08:22:59Z

The configuration changes in the migration docs should be fixed I guess https://github.com/getsentry/sentry-docs/pull/5939/files
Flutter and Android options naming stay the same for now but we'd need to account for the changes for iOS.

philipphofmann · 2023-01-10T10:55:03Z

@denrase I have changed to 8.0.0-rc.1 Not sure if there are more breaking changes, can you take a look?

All the breaking changes are in the Changelog. The migration docs are also almost ready. I have still a PR open for the final touches.

philipphofmann

We have many more breaking changes in the Changelog. I would be surprised if you don't need more changes in this PR.

I would expect the following changes to bubble up here

Rename APM tracking feature flags to tracing (#2450)
- Rename SentryOptions.enableAutoPerformanceTracking to enableAutoPerformanceTracing
- Rename SentryOptions.enableUIViewControllerTracking to enableUIViewControllerTracing
- Rename SentryOptions.enablePreWarmedAppStartTracking to enablePreWarmedAppStartTracing
- Rename SentryOptions.enableFileIOTracking to enableFileIOTracing
- Rename SentryOptions.enableCoreDataTracking to enableCoreDataTracing
Rename SentryOptions.enableOutOfMemoryTracking to SentryOptions.enableWatchdogTerminationTracking (#2499)

marandaneto · 2023-01-16T09:24:07Z

#1222 has fixes that are needed for this PR, this PR also has this PR as the target branch, maybe we merge it?

…ry/sentry-dart into chore/migrate-to-sentry-cocoa-v8

…efault (#1222)

denrase · 2023-01-16T12:56:19Z

@marandaneto CI seems happy now. Rdy for re-review.

marandaneto

Left 2 comments, but other than that, LGTM.

denrase added 4 commits December 19, 2022 14:04

bump to 8.0.0 beta 4

4610655

Rename SentryOptions.enableAutoPerformanceTracking to SentryOptions.e…

0c80668

…nableAutoPerformanceTracing

set name and version of hybrid sdk to native sdks

6cf9a4a

add changelog entry

98c2f38

denrase marked this pull request as ready for review December 19, 2022 14:24

denrase requested review from brustolin, krystofwoldrich and marandaneto as code owners December 19, 2022 14:24

marandaneto reviewed Dec 20, 2022

View reviewed changes

Comment thread flutter/lib/src/sentry_flutter_options.dart

marandaneto reviewed Dec 20, 2022

View reviewed changes

Comment thread flutter/test/integrations/init_native_sdk_integration_test.dart Outdated

denrase added 2 commits December 20, 2022 10:58

update native sdk integration test to match flutter sdk

10a5b3f

revert renaming to enableAutoPerformanceTracing because its out of sc…

0b3bf2f

…ope in this pr

denrase requested a review from marandaneto December 20, 2022 12:10

marandaneto reviewed Dec 20, 2022

View reviewed changes

Comment thread flutter/ios/Classes/SentryFlutterPluginApple.swift

denrase and others added 3 commits January 9, 2023 13:08

Merge branch 'v7.0.0' into chore/migrate-to-sentry-cocoa-v8

ef3d20a

# Conflicts: # flutter/ios/sentry_flutter.podspec

revert key rename

b1ce30e

Merge branch 'v7.0.0' into chore/migrate-to-sentry-cocoa-v8

d8b82b1

marandaneto reviewed Jan 10, 2023

View reviewed changes

Comment thread flutter/android/src/main/kotlin/io/sentry/flutter/SentryFlutterPlugin.kt

marandaneto reviewed Jan 10, 2023

View reviewed changes

Comment thread flutter/ios/Classes/SentryFlutterPluginApple.swift Outdated

marandaneto reviewed Jan 10, 2023

View reviewed changes

Comment thread flutter/ios/Classes/SentryFlutterPluginApple.swift Outdated

philipphofmann reviewed Jan 10, 2023

View reviewed changes

Merge branch 'v7.0.0' into chore/migrate-to-sentry-cocoa-v8

3b5d22e

marandaneto reviewed Jan 12, 2023

View reviewed changes

Comment thread flutter/android/src/main/kotlin/io/sentry/flutter/SentryFlutterPlugin.kt

fix api call

fae536b

remove duplicate dependency declaration

7b5c0e2

marandaneto and others added 5 commits January 16, 2023 10:27

Merge branch 'v7.0.0' into chore/migrate-to-sentry-cocoa-v8

e05af94

fix compile issues

ef980f3

Merge branch 'chore/migrate-to-sentry-cocoa-v8' of github.com:getsent…

4865774

…ry/sentry-dart into chore/migrate-to-sentry-cocoa-v8

remvoe comment

e177c32

bump depolyment targets

a98ed79

marandaneto reviewed Jan 16, 2023

View reviewed changes

Comment thread flutter/ios/Classes/SentryFlutterPluginApple.swift Outdated

denrase added 2 commits January 16, 2023 11:03

fix sdkversion call

e558a86

bump deployment target for min version test

eb2f1ff

denrase requested a review from marandaneto January 16, 2023 10:22

marandaneto and others added 4 commits January 16, 2023 13:06

Rename APM tracking feature flags to tracing and enable features by d…

ea6679c

…efault (#1222)

Merge branch 'v7.0.0' into chore/migrate-to-sentry-cocoa-v8

fbc515d

set osx (macos) min version in example Podfile

46c2b3f

update detekt

39fa2e5

marandaneto reviewed Jan 16, 2023

View reviewed changes

Comment thread CHANGELOG.md Outdated

marandaneto reviewed Jan 16, 2023

View reviewed changes

Comment thread min_version_test/ios/Flutter/AppFrameworkInfo.plist

marandaneto approved these changes Jan 16, 2023

View reviewed changes

denrase added 2 commits January 16, 2023 14:06

bump min os version

0779554

move changelog entries to unreleased section

1ae1fd6

marandaneto reviewed Jan 16, 2023

View reviewed changes

Comment thread CHANGELOG.md

marandaneto reviewed Jan 16, 2023

View reviewed changes

Comment thread CHANGELOG.md Outdated

denrase added 2 commits January 16, 2023 14:20

break up seperater prs into correct versions

c90e2c6

update title

6ecab55

marandaneto merged commit 8bea1f1 into v7.0.0 Jan 16, 2023

marandaneto deleted the chore/migrate-to-sentry-cocoa-v8 branch January 16, 2023 15:47

Uh oh!

Uh oh!

Conversation

denrase commented Dec 19, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📜 Description

💚 How did you test it?

📝 Checklist

Uh oh!

codecov-commenter commented Dec 19, 2022 • edited by codecov Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

Uh oh!

marandaneto commented Jan 10, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

marandaneto commented Jan 10, 2023

Uh oh!

philipphofmann commented Jan 10, 2023

Uh oh!

philipphofmann left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

marandaneto commented Jan 16, 2023

Uh oh!

Uh oh!

denrase commented Jan 16, 2023

Uh oh!

Uh oh!

Uh oh!

marandaneto left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

denrase commented Dec 19, 2022 •

edited

Loading

codecov-commenter commented Dec 19, 2022 •

edited by codecov Bot

Loading