Skip to content

Enha: Replace StackTrace.empty with StackTrace.current#1183

Merged
marandaneto merged 3 commits into
v7.0.0from
enha/replace-stacktrace-empty-with-stacktrace-current
Dec 13, 2022
Merged

Enha: Replace StackTrace.empty with StackTrace.current#1183
marandaneto merged 3 commits into
v7.0.0from
enha/replace-stacktrace-empty-with-stacktrace-current

Conversation

@denrase

@denrase denrase commented Dec 12, 2022

Copy link
Copy Markdown
Collaborator

📜 Description

Closes #1083

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • I updated the docs if needed
  • All tests passing
  • No breaking changes

🔮 Next steps

@marandaneto Any other places we need to replace `` ?

@denrase
denrase changed the base branch from main to v7.0.0 December 12, 2022 16:15
@denrase denrase changed the title Enha: Replace stacktrace empty with stacktrace current Enha: Replace StackTrace.empty with StackTrace.current Dec 12, 2022
@denrase denrase changed the title Enha: Replace StackTrace.empty with StackTrace.current Enha: Replace StackTrace.empty with StackTrace.current Dec 12, 2022
@denrase
denrase marked this pull request as ready for review December 12, 2022 16:21
Comment thread CHANGELOG.md

# Enhancements

- Enha: Replace `StackTrace.empty` with `StackTrace.current` ([#1183](https://github.com/getsentry/sentry-dart/pull/1183))

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • 🚫 The changelog entry seems to be part of an already released section ## 7.0.0.
    Consider moving the entry to the ## Unreleased section, please.

@marandaneto
marandaneto merged commit 918a6d8 into v7.0.0 Dec 13, 2022
@marandaneto
marandaneto deleted the enha/replace-stacktrace-empty-with-stacktrace-current branch December 13, 2022 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Replace StackTrace.empty with StackTrace.current

2 participants