Skip to content

Bump Flutter min to 3.0.0 and Dart to 2.17.0#1180

Merged
marandaneto merged 10 commits into
v7.0.0from
chore/bump-min-to-flutter-3.0.0-and-dart-2.17
Dec 14, 2022
Merged

Bump Flutter min to 3.0.0 and Dart to 2.17.0#1180
marandaneto merged 10 commits into
v7.0.0from
chore/bump-min-to-flutter-3.0.0-and-dart-2.17

Conversation

@denrase

@denrase denrase commented Dec 12, 2022

Copy link
Copy Markdown
Collaborator

📜 Description

Closes #1162

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • I updated the docs if needed
  • All tests passing
  • No breaking changes

@denrase
denrase changed the base branch from main to v7.0.0 December 12, 2022 13:24
Comment thread file/lib/src/sentry_file.dart Outdated
Comment thread CHANGELOG.md
- theme
- Removed isolate name from Dart context. It's now reported via the threads interface. It can be enabled via `options.attachThreads`
- Use `sentryClientName` instead of `sdk.identifier` ([#1135](https://github.com/getsentry/sentry-dart/pull/1135))
- Bump Flutter min to 3.0.0 and Dart to 2.17.0 ([#1180](https://github.com/getsentry/sentry-dart/pull/1180))

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • 🚫 The changelog entry seems to be part of an already released section ## 7.0.0.
    Consider moving the entry to the ## Unreleased section, please.

@denrase
denrase marked this pull request as ready for review December 12, 2022 13:32
Comment thread min_version_test/pubspec.yaml Outdated
@denrase
denrase requested a review from marandaneto December 12, 2022 16:25
@ueman

ueman commented Dec 12, 2022

Copy link
Copy Markdown
Collaborator

I believe you can also fix this issue:

// The editor says it's fine without a `?` but the compiler complains
// if it's missing
// ignore: invalid_null_aware_operator
final languageTag = _window?.locale?.toLanguageTag();

@marandaneto

Copy link
Copy Markdown
Contributor

https://github.com/getsentry/sentry-dart/blob/main/dart/lib/src/utils/hash_code.dart can likely be gone as well.

@codecov-commenter

codecov-commenter commented Dec 13, 2022

Copy link
Copy Markdown

Codecov Report

❗ No coverage uploaded for pull request base (v7.0.0@3e6109b). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff            @@
##             v7.0.0    #1180   +/-   ##
=========================================
  Coverage          ?   88.03%           
=========================================
  Files             ?      120           
  Lines             ?     3802           
  Branches          ?        0           
=========================================
  Hits              ?     3347           
  Misses            ?      455           
  Partials          ?        0           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@marandaneto

Copy link
Copy Markdown
Contributor

@marandaneto
marandaneto merged commit 265f589 into v7.0.0 Dec 14, 2022
@marandaneto
marandaneto deleted the chore/bump-min-to-flutter-3.0.0-and-dart-2.17 branch December 14, 2022 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bump Flutter min to 3.0.0 and Dart to 2.17.0

4 participants